Closed Bug 1109812 Opened 5 years ago Closed 5 years ago

Categories

(Firefox :: General, defect)

defect
Not set
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 37
Iteration:
37.2
Tracking Status
firefox35 --- unaffected
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file, 1 obsolete file)

We should not have a debugger; statement checked in to the tree unless there is some bug that can only be reproduced under special conditions and we need developers to note how they were able to hit this breakpoint.

I was running the debugger today and it stopped when it hit http://mxr.mozilla.org/mozilla-central/source/browser/modules/UITour.jsm?rev=870b15a253e8#1648
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8534530 - Flags: review?(bmcbride)
Iteration: --- → 37.1
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Iteration: 37.1 → 37.2
Comment on attachment 8534530 [details] [diff] [review]
Patch

Review of attachment 8534530 [details] [diff] [review]:
-----------------------------------------------------------------

I noted the debugger statement in my review but I guess that was missed.

You have many other unrelated things in this patch which I assume was a mistake.

rs=me on the fixed version.
Attachment #8534530 - Flags: review?(bmcbride) → review-
Attached patch Patch with r+Splinter Review
Attachment #8534530 - Attachment is obsolete: true
Attachment #8534541 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/dd59cf445ac2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment on attachment 8534541 [details] [diff] [review]
Patch with r+

[Triage Comment]

Trivial bugfix.
Attachment #8534541 - Flags: approval-mozilla-beta+
Attachment #8534541 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.