Remove the C11 _Static_assert which checks a runtime condition

RESOLVED FIXED in mozilla37

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nICEr])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
clang-cl enables C11 and therefore complains on this code:
static_assert expression is not an integral constant expression.
(Assignee)

Comment 1

4 years ago
Created attachment 8534566 [details] [diff] [review]
Remove the C11 _Static_assert which checks a runtime condition
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan.akhgari
Blocks: 752004
(Assignee)

Updated

4 years ago
Attachment #8534566 - Flags: review?(adam)

Comment 2

4 years ago
Comment on attachment 8534566 [details] [diff] [review]
Remove the C11 _Static_assert which checks a runtime condition

Review of attachment 8534566 [details] [diff] [review]:
-----------------------------------------------------------------

Yep. I've tried to figure out what I was trying to do here, but I'm coming up blank. The way this is structured, it can't be checked at compile time. I believe that removing the static assert is the right thing to do.
Attachment #8534566 - Flags: review?(adam) → review+
Is this change upstreamed?

Comment 4

4 years ago
(In reply to Masatoshi Kimura [:emk] from comment #3)
> Is this change upstreamed?

Thanks for the reminder. I'm marking the whiteboard accordingly to make sure it gets into the next upstream patch.
Whiteboard: [nICEr]
https://hg.mozilla.org/mozilla-central/rev/6143b7a147cf
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.