Closed Bug 1109841 Opened 8 years ago Closed 8 years ago

Remove the C11 _Static_assert which checks a runtime condition

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

(Whiteboard: [nICEr])

Attachments

(1 file)

Remove the C11 _Static_assert which checks a runtime condition
1.20 KB, patch
abr
: review+
Details | Diff | Splinter Review 
clang-cl enables C11 and therefore complains on this code:
static_assert expression is not an integral constant expression.
Assignee: nobody → ehsan.akhgari
Blocks: winclang
Attachment #8534566 - Flags: review?(adam)
Comment on attachment 8534566 [details] [diff] [review]
Remove the C11 _Static_assert which checks a runtime condition

Review of attachment 8534566 [details] [diff] [review]:
-----------------------------------------------------------------

Yep. I've tried to figure out what I was trying to do here, but I'm coming up blank. The way this is structured, it can't be checked at compile time. I believe that removing the static assert is the right thing to do.
Attachment #8534566 - Flags: review?(adam) → review+
Is this change upstreamed?
(In reply to Masatoshi Kimura [:emk] from comment #3)
> Is this change upstreamed?

Thanks for the reminder. I'm marking the whiteboard accordingly to make sure it gets into the next upstream patch.
Whiteboard: [nICEr]
https://hg.mozilla.org/mozilla-central/rev/6143b7a147cf
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.