1109887 - Showing duration on event edit shouldn't show anything if duration is not known

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Peter Bengtsson [:peterbe]]

Attachment: Screenshot 2014-12-10 14.15.07.png

See attached screenshot. 

The template is event_edit.html

Comment 1

[Leonard Camacho [:lcamacho]]

Looking at code this seems to be done https://github.com/mozilla/airmozilla/blob/master/airmozilla/manage/templates/manage/event_edit.html#L75

Comment 2

[Peter Bengtsson [:peterbe]]

Strange! Thing is, I managed to take that screenshot but the code was never without the `if event.duration`. It's always been there (see https://github.com/mozilla/airmozilla/commit/9976d7ca866a3bdc7660df3529d77051c0cb1910#diff-7) 

Now I'm wondering if there's a particular value for `event.duration` that might make `show_duration()` function (https://github.com/mozilla/airmozilla/blob/master/airmozilla/base/helpers.py#L34) possibly return an empty string.

Comment 3

[Leonard Camacho [:lcamacho]]

I think this could happen when the duration is < 60 seconds and include_seconds=False, maybe the way to go is to add a new case and print something like 'less than a minute'.

Comment 4

[Peter Bengtsson [:peterbe]]

(In reply to Leonard Camacho [:lcamacho] from comment #3)
> I think this could happen when the duration is < 60 seconds and
> include_seconds=False, maybe the way to go is to add a new case and print
> something like 'less than a minute'.

I would actually like to see "32 seconds" for example, if it's less than 1 minute. 
So, do we just need to pass `include_seconds=True` there in the event_edit.html template?

Do you want to write a PR that does this? One with a test that renders the event_edit.html view and looks for it there.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/cffeba421066e537f52e2fb9c6f6e2022bc96ac8
Fixes bug 1109887

https://github.com/mozilla/airmozilla/commit/e2b43a915c6198d92008e98225a040960ce83ace
Merge pull request #163 from lcamacho/bug-1109887

Fixes bug 1109887