1109894 - repository_manifest.py allows for feeding incorrect URLs

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

I triggered a talos builder without specifying a revision and that set a revision of "None".

That means that down the road we pass a manifest URL that has no revision.
Instead of failling, repository_manifest.py considers it as one of the valid 404 results and returns the default mozharness repositories. See double forward slashes [1].

We either break --manifest-url into multiple parameters or we do a regex analysis of the values given.

The message from hg is "error: revision not found: testing" perhaps that is something we can look for in the response besides the 404 code.

[1]
python repository_manifest.py --default-repo https://hg.mozilla.org/build/mozharness --default-revision production --manifest-url https://hg.mozilla.org/try/raw-file//testing/mozharness/mozharness.json --timeout 1 --max-retries 1
script_repo_url: https://hg.mozilla.org/build/mozharness
script_repo_revision: production

Comment 1

[Armen [:armenzg]]

This also happens on desktop test builders.
I guess I never called "force build" without setting the revision to something.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

I think this got fixed or behavior changed during BB -> TC migration, hence this bug outlived its usefulness.
Closing this, feel free to reopen if I'm wrong.