Send the correct -m flags to clang-cl when building libvpx; r=jrmuizel

RESOLVED FIXED in mozilla37

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8534626 [details] [diff] [review]
Send the correct -m flags to clang-cl when building libvpx; r=jrmuizel
(Assignee)

Updated

4 years ago
Attachment #8534626 - Flags: review?(jmuizelaar)
Comment on attachment 8534626 [details] [diff] [review]
Send the correct -m flags to clang-cl when building libvpx; r=jrmuizel

Review of attachment 8534626 [details] [diff] [review]:
-----------------------------------------------------------------

Why doesn't

::: media/libvpx/moz.build
@@ +91,5 @@
>          SOURCES += [
>              '%s/sources/android/cpufeatures/cpu-features.c' % CONFIG['ANDROID_NDK'],
>          ]
>  
> +if not CONFIG['_MSC_VER'] or CONFIG['CLANG_CL']:

I would find this easier to read if you reversed the condition. i.e. 

if CONFIG['CLANG_CL'] or not CONFIG['_MSC_VER']

This removes ambiguity of the not.
Attachment #8534626 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> Why doesn't

?

> ::: media/libvpx/moz.build
> @@ +91,5 @@
> >          SOURCES += [
> >              '%s/sources/android/cpufeatures/cpu-features.c' % CONFIG['ANDROID_NDK'],
> >          ]
> >  
> > +if not CONFIG['_MSC_VER'] or CONFIG['CLANG_CL']:
> 
> I would find this easier to read if you reversed the condition. i.e. 
> 
> if CONFIG['CLANG_CL'] or not CONFIG['_MSC_VER']
> 
> This removes ambiguity of the not.

OK, will do.
https://hg.mozilla.org/mozilla-central/rev/1ad46fb370ea
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
You need to log in before you can comment on or make changes to this bug.