Closed Bug 1109910 Opened 6 years ago Closed 6 years ago
Info from doc Shell into Necko
The *.idl  as well as it's implementation files should move somewhere into Necko. DocShell doesn't feel to be the right place for the loadInfo anymore.  http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsILoadInfo.idl
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Jonas, Steve, as discussed LoadInfo seems like it doesn't belong into docshell anymore, but rather should live in necko. Currently we use EXPORTS.mozilla for Loadinfo, but potentially you prefer to use EXPORTS.mozilla.net. I am fine either way, just let me know and I'll update if needed.
Attachment #8565718 - Flags: review?(jonas) → review+
Comment on attachment 8565718 [details] [diff] [review] move_loadinfo_into_necko.patch Review of attachment 8565718 [details] [diff] [review]: ----------------------------------------------------------------- Looks sane to me. r=me pending try and all the rest.
Attachment #8565718 - Flags: review?(sworkman) → review+
Target Milestone: --- → mozilla38
sorry had to back this out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=6725104&repo=mozilla-inbound
As discussed with RyanVM over IRC, I am touching CLOBBER and reland: https://hg.mozilla.org/integration/mozilla-inbound/rev/73e586b9f04f
Still hitting the same errors as before. Backed out. https://hg.mozilla.org/integration/mozilla-inbound/rev/dd8e580f0e1d
I think you're somehow interacting badly with bug 1131557. https://hg.mozilla.org/integration/mozilla-inbound/rev/4ef497dc6f9b Which works out nicely for you, because I'm about to back that out anyway.
Ok, I left a comment for Dragana: https://bugzilla.mozilla.org/show_bug.cgi?id=1131557#c22 which allows us to reland this patch (as soon as inbound opens up).
Alright, this one should stick: https://hg.mozilla.org/integration/mozilla-inbound/rev/9f6ba4598996
You need to log in before you can comment on or make changes to this bug.