1109910 - Move LoadInfo from docShell into Necko

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Christoph Kerschbaumer [:ckerschb]]

The *.idl [1] as well as it's implementation files should move somewhere into Necko. DocShell doesn't feel to be the right place for the loadInfo anymore.

[1] http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsILoadInfo.idl

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: move_loadinfo_into_necko.patch

Jonas, Steve, as discussed LoadInfo seems like it doesn't belong into docshell anymore, but rather should live in necko.

Currently we use EXPORTS.mozilla for Loadinfo, but potentially you prefer to use EXPORTS.mozilla.net. I am fine either way, just let me know and I'll update if needed.

Comment 2

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 8565718 [details] [diff] [review]
move_loadinfo_into_necko.patch

Review of attachment 8565718 [details] [diff] [review]:
-----------------------------------------------------------------

Looks sane to me. r=me pending try and all the rest.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5540f3fcce

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back this out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=6725104&repo=mozilla-inbound

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

As discussed with RyanVM over IRC, I am touching CLOBBER and reland:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/73e586b9f04f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Still hitting the same errors as before. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd8e580f0e1d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I think you're somehow interacting badly with bug 1131557.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ef497dc6f9b

Which works out nicely for you, because I'm about to back that out anyway.

Comment 8

[Christoph Kerschbaumer [:ckerschb]]

Ok, I left a comment for Dragana:
  https://bugzilla.mozilla.org/show_bug.cgi?id=1131557#c22
which allows us to reland this patch (as soon as inbound opens up).

Comment 9

[Christoph Kerschbaumer [:ckerschb]]

Alright, this one should stick:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/9f6ba4598996

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9f6ba4598996