Remove collection migration code from FTU

RESOLVED FIXED

Status

Firefox OS
Gaia::First Time Experience
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
It is no longer needed now that we don't need to support migrations from 1.4 -> 2.2+.
Created attachment 8534642 [details] [review]
[PullReq] KevinGrandon:bug_1109920_remove_ftu_migration to mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8534642 [details] [review]
[PullReq] KevinGrandon:bug_1109920_remove_ftu_migration to mozilla-b2g:master

Sam - could you give this a review when you have time? Thanks!
Attachment #8534642 - Flags: review?(sfoster)
(In reply to Kevin Grandon :kgrandon from comment #2)
> Comment on attachment 8534642 [details] [review]
> [PullReq] KevinGrandon:bug_1109920_remove_ftu_migration to mozilla-b2g:master
> 
> Sam - could you give this a review when you have time? Thanks!

The patch itself looks fine, but what is the decision that makes this a requirement? Where/when did we decide not to support migrations from 1.4? For the purposes of testing, what are the expected results?
Flags: needinfo?(kgrandon)
(Assignee)

Comment 4

3 years ago
We have decided that we will only support migrations across 2 versions. E.g., 1.3 -> 2.0, or 1.4 -> 2.1.

The *lowest* possible version number to migrate to 2.2 is 2.0, so for that migration you do not need the FTU migration step.

For the purposes of testing, I suppose you could flash a device and make sure smart collections show up. Previously this would've migrated user-created smart collections to the home screen. We no longer need to do that.
Flags: needinfo?(kgrandon)
Comment on attachment 8534642 [details] [review]
[PullReq] KevinGrandon:bug_1109920_remove_ftu_migration to mozilla-b2g:master

Thanks for doing this. Honestly I'm not clear why this was in the Tutorial code to begin with and am glad to see it gone :) 

QA note: this patch removes legacy migration code for 1.x smart collections that is no longer supported or needed (users will upgrade to 2.0 then 2.x). The automated tests give us the best coverage. If you want to manually verify, just flash/reset and step through the FTU tutorial to confirm there are no new blockages or exceptions.
Attachment #8534642 - Flags: review?(sfoster) → review+
(Assignee)

Comment 6

3 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/a2e8446022cbad0ec2d3c3561619820433e45181
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
You need to log in before you can comment on or make changes to this bug.