Closed
Bug 1109923
Opened 9 years ago
Closed 9 years ago
Fix the panel views in the ui-showcase
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox35 fixed, firefox36 fixed, firefox37 fixed)
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
19.05 KB,
patch
|
NiKo
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Recent changes to enable rooms and other things, mean that the panel views in the ui-showcase are now out of date. Although we'll probably get rid of the older views soon, for now, lets just get it doing what its meant to. At the same time, we can switch to some more mozLoop parameter passing.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8534646 -
Flags: review?(nperriault)
Comment on attachment 8534646 [details] [diff] [review] Fix the Loop panel views in the ui-showcase. Review of attachment 8534646 [details] [diff] [review]: ----------------------------------------------------------------- I like this a lot, r=me. I feel like we could even introduce a MozLoopMixin later at some point ;)
Attachment #8534646 -
Flags: review?(nperriault) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6704068cbf06
Iteration: --- → 37.2
Points: --- → 1
Target Milestone: --- → mozilla37
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6704068cbf06
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 5•9 years ago
|
||
Comment on attachment 8534646 [details] [diff] [review] Fix the Loop panel views in the ui-showcase. Approval Request Comment [Feature/regressing bug #]: Rooms [User impact if declined]: at most minor merge issues; can't run UI developer tool on 35 or 36. [Describe test coverage new/current, TBPL]: not part of build [Risks and why]: No risk - NPOTB [String/UUID change made/needed]: none
Attachment #8534646 -
Flags: approval-mozilla-beta?
Attachment #8534646 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8534646 -
Flags: approval-mozilla-beta?
Attachment #8534646 -
Flags: approval-mozilla-beta+
Attachment #8534646 -
Flags: approval-mozilla-aurora?
Attachment #8534646 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•