Closed
Bug 1109940
Opened 9 years ago
Closed 9 years ago
Add symbol wrapping for Android DNS resolver
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox36 fixed, firefox37 fixed)
RESOLVED
FIXED
mozilla37
People
(Reporter: esawin, Assigned: esawin)
References
Details
Attachments
(1 file, 1 obsolete file)
5.58 KB,
patch
|
esawin
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 1077366 removed all symbol wrappers for Android, which breaks the conditional getaddrinfo call chaining for Android 3 and later versions. We need to add the symbol wrappers back for the Android DNS resolver functions.
Assignee | ||
Comment 1•9 years ago
|
||
Updated•9 years ago
|
Updated•9 years ago
|
status-firefox36:
--- → affected
Comment 2•9 years ago
|
||
Comment on attachment 8534659 [details] [diff] [review] wrap-dns-resolver-func Review of attachment 8534659 [details] [diff] [review]: ----------------------------------------------------------------- ::: memory/build/mozmemory_wrap.h @@ +62,5 @@ > + * - On Android, getaddrinfo, freeaddrinfo and gai_strerror are prefixed with > + * "__wrap_". Additionally, C++ allocation functions (operator new/delete) > + * are also exported and unprefixed. > + * > + * - On Gonk, all functions are left unprefixed. Additionally, This comment is about memory allocator symbols. Please don't change it.
Attachment #8534659 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Removed comment edits.
Attachment #8534659 -
Attachment is obsolete: true
Attachment #8534993 -
Flags: review+
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=be94e75119b9 https://hg.mozilla.org/integration/fx-team/rev/ca8735e95bad
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ca8735e95bad
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Assignee | ||
Comment 7•9 years ago
|
||
The changeset https://hg.mozilla.org/integration/fx-team/rev/d9fd6f35c45d references this bug, but actually belongs to bug 1110529.
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8534993 [details] [diff] [review] wrap-dns-resolver Approval Request Comment [Feature/regressing bug #]: bug 1077366 [User impact if declined]: blocks bug 991923, major connectivity issues when switching networks or using VPNs [Describe test coverage new/current, TBPL]: has been on nightly for some days [Risks and why]: none, failure to resolve function symbols is deterministic and would have rendered nightly unable to resolve any address or load any page [String/UUID change made/needed]: none
Attachment #8534993 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8534993 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•