Add symbol wrapping for Android DNS resolver

RESOLVED FIXED in Firefox 36

Status

defect
RESOLVED FIXED
5 years ago
Last year

People

(Reporter: esawin, Assigned: esawin)

Tracking

unspecified
mozilla37
x86_64
Android
Dependency tree / graph

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
Bug 1077366 removed all symbol wrappers for Android, which breaks the conditional getaddrinfo call chaining for Android 3 and later versions.

We need to add the symbol wrappers back for the Android DNS resolver functions.
Assignee

Updated

5 years ago
Depends on: 1077366
Assignee

Comment 1

5 years ago
Posted patch wrap-dns-resolver-func (obsolete) — Splinter Review
Assignee: nobody → esawin
Status: NEW → ASSIGNED
Attachment #8534659 - Flags: review?(mh+mozilla)
Blocks: 1077366
No longer depends on: 1077366
Comment on attachment 8534659 [details] [diff] [review]
wrap-dns-resolver-func

Review of attachment 8534659 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/build/mozmemory_wrap.h
@@ +62,5 @@
> + * - On Android, getaddrinfo, freeaddrinfo and gai_strerror are prefixed with
> + *   "__wrap_". Additionally, C++ allocation functions (operator new/delete)
> + *   are also exported and unprefixed.
> + *
> + * - On Gonk, all functions are left unprefixed. Additionally,

This comment is about memory allocator symbols. Please don't change it.
Attachment #8534659 - Flags: review?(mh+mozilla) → review+
Assignee

Comment 3

5 years ago
Removed comment edits.
Attachment #8534659 - Attachment is obsolete: true
Attachment #8534993 - Flags: review+
Assignee

Updated

5 years ago
Blocks: 991923
Assignee

Updated

5 years ago
Blocks: 1110529
https://hg.mozilla.org/mozilla-central/rev/ca8735e95bad
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Assignee

Comment 7

5 years ago
The changeset https://hg.mozilla.org/integration/fx-team/rev/d9fd6f35c45d references this bug, but actually belongs to bug 1110529.
Assignee

Comment 8

5 years ago
Comment on attachment 8534993 [details] [diff] [review]
wrap-dns-resolver

Approval Request Comment
[Feature/regressing bug #]: bug 1077366 
[User impact if declined]: blocks bug 991923, major connectivity issues when switching networks or using VPNs
[Describe test coverage new/current, TBPL]: has been on nightly for some days
[Risks and why]: none, failure to resolve function symbols is deterministic and would have rendered nightly unable to resolve any address or load any page
[String/UUID change made/needed]: none
Attachment #8534993 - Flags: approval-mozilla-aurora?
Attachment #8534993 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.