Mark more directories as FAIL_ON_WARNINGS, with a few compiler and platform exceptions

RESOLVED FIXED in mozilla37

Status

defect
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla37
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

No description provided.
dholbert: when you have time, can you please verify that your Ubuntu clang builds still work with these two FAIL_ON_WARNINGS patches?

The platforms on Try are green:
https://tbpl.mozilla.org/?tree=Try&rev=f3edaa8b70fe
Attachment #8534837 - Flags: feedback?(dholbert)
Comment on attachment 8534837 [details] [diff] [review]
fail-part-2.patch

Builds fine for me! (this is a clang 3.5 debug build, with a few local patches to fix known warnings-as-errors failures in clang 3.5)

Thanks for checking.
Attachment #8534837 - Flags: feedback?(dholbert) → feedback+
Comment on attachment 8534834 [details] [diff] [review]
fail-part-1.patch

Part 1: Mark more directories as FAIL_ON_WARNINGS. This bug covers most of the tree's remaining moz.build files that have UNIFIED_SOURCES or SOURCES with cpp files.
Attachment #8534834 - Flags: review?(gps)
Comment on attachment 8534837 [details] [diff] [review]
fail-part-2.patch

Part 2: Mark some directories as FAIL_ON_WARNINGS for some compilers.
Attachment #8534837 - Flags: review?(gps)
Comment on attachment 8534834 [details] [diff] [review]
fail-part-1.patch

Review of attachment 8534834 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, I'll rubber stamp this.
Attachment #8534834 - Flags: review?(gps) → review+
Attachment #8534837 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/ce7402c3a5a2
https://hg.mozilla.org/mozilla-central/rev/0163b91e7478
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Depends on: 1115481
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.