1110031 - Mark more directories as FAIL_ON_WARNINGS, with a few compiler and platform exceptions

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fail-part-1.patch

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: fail-part-2.patch

dholbert: when you have time, can you please verify that your Ubuntu clang builds still work with these two FAIL_ON_WARNINGS patches?

The platforms on Try are green:
https://tbpl.mozilla.org/?tree=Try&rev=f3edaa8b70fe

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8534837 [details] [diff] [review]
fail-part-2.patch

Builds fine for me! (this is a clang 3.5 debug build, with a few local patches to fix known warnings-as-errors failures in clang 3.5)

Thanks for checking.

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 8534834 [details] [diff] [review]
fail-part-1.patch

Part 1: Mark more directories as FAIL_ON_WARNINGS. This bug covers most of the tree's remaining moz.build files that have UNIFIED_SOURCES or SOURCES with cpp files.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 8534837 [details] [diff] [review]
fail-part-2.patch

Part 2: Mark some directories as FAIL_ON_WARNINGS for some compilers.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8534834 [details] [diff] [review]
fail-part-1.patch

Review of attachment 8534834 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, I'll rubber stamp this.

Comment 6

[Chris Peterson [:cpeterson]]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce7402c3a5a2
https://hg.mozilla.org/integration/mozilla-inbound/rev/0163b91e7478

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ce7402c3a5a2
https://hg.mozilla.org/mozilla-central/rev/0163b91e7478