Closed
Bug 1110031
Opened 9 years ago
Closed 9 years ago
Mark more directories as FAIL_ON_WARNINGS, with a few compiler and platform exceptions
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla37
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(2 files)
20.19 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
1.89 KB,
patch
|
gps
:
review+
dholbert
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
dholbert: when you have time, can you please verify that your Ubuntu clang builds still work with these two FAIL_ON_WARNINGS patches? The platforms on Try are green: https://tbpl.mozilla.org/?tree=Try&rev=f3edaa8b70fe
Attachment #8534837 -
Flags: feedback?(dholbert)
Comment 2•9 years ago
|
||
Comment on attachment 8534837 [details] [diff] [review] fail-part-2.patch Builds fine for me! (this is a clang 3.5 debug build, with a few local patches to fix known warnings-as-errors failures in clang 3.5) Thanks for checking.
Attachment #8534837 -
Flags: feedback?(dholbert) → feedback+
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8534834 [details] [diff] [review] fail-part-1.patch Part 1: Mark more directories as FAIL_ON_WARNINGS. This bug covers most of the tree's remaining moz.build files that have UNIFIED_SOURCES or SOURCES with cpp files.
Attachment #8534834 -
Flags: review?(gps)
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8534837 [details] [diff] [review] fail-part-2.patch Part 2: Mark some directories as FAIL_ON_WARNINGS for some compilers.
Attachment #8534837 -
Flags: review?(gps)
Comment 5•9 years ago
|
||
Comment on attachment 8534834 [details] [diff] [review] fail-part-1.patch Review of attachment 8534834 [details] [diff] [review]: ----------------------------------------------------------------- Sure, I'll rubber stamp this.
Attachment #8534834 -
Flags: review?(gps) → review+
Updated•9 years ago
|
Attachment #8534837 -
Flags: review?(gps) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Thanks! https://hg.mozilla.org/integration/mozilla-inbound/rev/ce7402c3a5a2 https://hg.mozilla.org/integration/mozilla-inbound/rev/0163b91e7478
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ce7402c3a5a2 https://hg.mozilla.org/mozilla-central/rev/0163b91e7478
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Blocks: 1113210
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•