1110056 - Merge nsMathMLmphantomFrame into nsMathMLmrowFrame

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang (:fredw)]

See discussion on bug 1108378.

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Patch

So the difference with this approach is that authors can now use CSS to override the visibility of the <mphantom> or of one of its descendants. I don't think the MathML spec says anything against that and actually saying that <mphantom>=<mrow>+visibility:hidden makes the behavior clear to authors.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=caf4ca9488c7

Comment 2

[James Kitchener (:jkitch)]

Comment on attachment 8560883 [details] [diff] [review]
Patch

Review of attachment 8560883 [details] [diff] [review]:
-----------------------------------------------------------------

This is helpful for overflow=linebreak support as it allows intra-frame linebreaks in mphantom without additional effort.

A comment in nsMathMLmrowFrame.h indicating that it doubles for mphantom (and mstyle for that matter) would be nice.

::: layout/reftests/mathml/reftest.list
@@ +19,5 @@
>  != mirror-op-3.html mirror-op-3-ref.html
>  != mirror-op-4.html mirror-op-4-ref.html
>  == dynamic-mi.xhtml dynamic-mi-ref.xhtml
> +== mphantom-1.html mphantom-1-ref.html 
> +== mphantom-2.html mphantom-2-ref.html 

Nit: trailing whitespace

Comment 3

[Frédéric Wang (:fredw)]

(In reply to James Kitchener (:jkitch) from comment #2)
> A comment in nsMathMLmrowFrame.h indicating that it doubles for mphantom
> (and mstyle for that matter) would be nice.

Sorry, what do you mean by "it doubles"? You mean adding that the class is also used for mstyle/mphantom?

Comment 4

[James Kitchener (:jkitch)]

Yes, in the same way that nsMathMLmmultiscriptsFrame.h mentions that it gets used for msup, msub and msubsup.

Comment 5

[Frédéric Wang (:fredw)]

Attachment: Patch V2

Comment 6

[Frédéric Wang (:fredw)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=caf4ca9488c7

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd37bba635eb

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd37bba635eb