Merge nsMathMLmphantomFrame into nsMathMLmrowFrame

RESOLVED FIXED in Firefox 38

Status

()

Core
MathML
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: fredw, Assigned: fredw)

Tracking

Trunk
mozilla38
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
See discussion on bug 1108378.
(Assignee)

Updated

4 years ago
Assignee: nobody → fred.wang
(Assignee)

Comment 1

4 years ago
Created attachment 8560883 [details] [diff] [review]
Patch

So the difference with this approach is that authors can now use CSS to override the visibility of the <mphantom> or of one of its descendants. I don't think the MathML spec says anything against that and actually saying that <mphantom>=<mrow>+visibility:hidden makes the behavior clear to authors.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=caf4ca9488c7
Attachment #8560883 - Flags: review?(jkitch.bug)
Comment on attachment 8560883 [details] [diff] [review]
Patch

Review of attachment 8560883 [details] [diff] [review]:
-----------------------------------------------------------------

This is helpful for overflow=linebreak support as it allows intra-frame linebreaks in mphantom without additional effort.

A comment in nsMathMLmrowFrame.h indicating that it doubles for mphantom (and mstyle for that matter) would be nice.

::: layout/reftests/mathml/reftest.list
@@ +19,5 @@
>  != mirror-op-3.html mirror-op-3-ref.html
>  != mirror-op-4.html mirror-op-4-ref.html
>  == dynamic-mi.xhtml dynamic-mi-ref.xhtml
> +== mphantom-1.html mphantom-1-ref.html 
> +== mphantom-2.html mphantom-2-ref.html 

Nit: trailing whitespace
Attachment #8560883 - Flags: review?(jkitch.bug) → review+
(Assignee)

Comment 3

4 years ago
(In reply to James Kitchener (:jkitch) from comment #2)
> A comment in nsMathMLmrowFrame.h indicating that it doubles for mphantom
> (and mstyle for that matter) would be nice.

Sorry, what do you mean by "it doubles"? You mean adding that the class is also used for mstyle/mphantom?
(Assignee)

Updated

4 years ago
Flags: needinfo?(jkitch.bug)
Yes, in the same way that nsMathMLmmultiscriptsFrame.h mentions that it gets used for msup, msub and msubsup.
Flags: needinfo?(jkitch.bug)
(Assignee)

Comment 5

4 years ago
Created attachment 8561534 [details] [diff] [review]
Patch V2
Attachment #8560883 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/cd37bba635eb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox38: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.