1110095 - Messages -> Create filter from message broken by bug 1085205

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[:aceman]

If the "Create filter from message" is invoked from the Message menu, not from message header view, the filter editor comes up empty, due to an error:
Error: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgSearchTerm.getAttributeFromString]
Source File: chrome://messenger/content/FilterEditor.js
Line: 96

Presumably because this method sends and empty field which should be prefilled in the editor. It should default to "Sender" in that case.

Comment 1

[:aceman]

Attachment: patch

Comment 2

[:aceman]

Attachment: patch v2

The previous version wouldn't work if fieldName is Subject as that has an attrib value of 0.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 8535181 [details] [diff] [review]
patch v2

Review of attachment 8535181 [details] [diff] [review]:
-----------------------------------------------------------------

Please rephrase the commit message. Besides that and a nit, looks good to me. r=mkmelin

::: mail/base/content/mailWindowOverlay.js
@@ +2298,5 @@
>      // We have to do prefill filter so we are going to launch the
>      // filterEditor dialog and prefill that with the emailAddress.
>      args = { filterList: folder.getEditableFilterList(msgWindow),
> +             filterName: emailAddress };
> +    if (fieldName)

maybe add a comment about what this is

::: mailnews/base/search/content/FilterEditor.js
@@ +90,5 @@
>  
>          var term = gFilter.createTerm();
>  
> +        term.attrib = Components.interfaces.nsMsgSearchAttrib.Default;
> +        if (("fieldName" in args) && (args.fieldName != "")) {

&& args.fieldName

Comment 4

[:aceman]

Attachment: patch v2.1

Thanks.

Comment 5

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/8d3f8239c7b7 -> FIXED