1110105 - Get rid of "-Promise" from wantGlobalProperties

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Gabor Krizsanits (INACTIVE)]

We talked about this with Bobby and this should go for various reasons, like the side effect it comes with and also since we have no good reason to keep it. I will fix this once I have a few minutes for it. Flagging myself on it so I won't forget it.

Comment 1

[Gabor Krizsanits (INACTIVE)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=294495b0d6b0

Comment 2

[Gabor Krizsanits (INACTIVE)]

Attachment: Remove "-Promise" from wantGlobalProperties. v1

Comment 3

[Masatoshi Kimura [:emk]]

https://developer.mozilla.org/en-US/docs/Components.utils.Sandbox will need an update.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8535586 [details] [diff] [review]
Remove "-Promise" from wantGlobalProperties. v1

Review of attachment 8535586 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. r=bholley

::: js/xpconnect/src/xpcprivate.h
@@ -3353,5 @@
>      GlobalProperties() {
>        mozilla::PodZero(this);
>  
> -      // Promise is supposed to be part of ES, and therefore should appear on
> -      // every global.

Please move this comment to the code in Sandbox.cpp where we install the promise constructor for sandboxes.

Comment 5

[Gabor Krizsanits (INACTIVE)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d9be695d380

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4d9be695d380

Comment 7

[Will Bamberg [:wbamberg]]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> https://developer.mozilla.org/en-US/docs/Components.utils.Sandbox will need
> an update.

Done, and thanks for flagging.