Run an experiment: disable Flash protected mode and see how that affects the plugin crash/hang and BHR data

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
On Windows 7+, we'd like to run an experiment on beta to force-disable Flash protected mode and see how that affects the Flash crash/hang rates.

To reduce data latency, I'm going to see if we can record all the necessary data in the telemetry payload instead of relying on FHR.
(Assignee)

Updated

3 years ago
Depends on: 1110818
(Assignee)

Updated

3 years ago
Depends on: 1111791
(Assignee)

Comment 1

3 years ago
Created attachment 8536855 [details] [diff] [review]
flash-protected
Attachment #8536855 - Flags: review?(felipc)
Comment on attachment 8536855 [details] [diff] [review]
flash-protected

Review of attachment 8536855 [details] [diff] [review]:
-----------------------------------------------------------------

::: experiments/flash-protectedmode-beta/code/bootstrap.js
@@ +11,5 @@
> +function startup() {
> +  // Seems startup() function is launched twice after install, we're
> +  // unsure why so far. We only want it to run once.
> +  if (gStarted) {
> +    Cu.reportError("startup() function was launched twice; making second run return.");

this is an artifact of the way that experiments are installed/started up by being disabled by default and then getting enabled. I meant to file a bug about it last time but I think I never did.

Which is to say this is a known thing, no need to Cu.reportError. But yeah, keep the `if (gStarted) { return; }`.

@@ +45,5 @@
> +    });
> +}
> +
> +function shutdown() {
> +  gStarted = false;

Probably no point in setting this to false, unless you want to properly support hot-disabling the experiment and having it undo its effect. But in that case you will also need to clear the pref that was set.
Attachment #8536855 - Flags: review?(felipc) → review+
(Assignee)

Comment 3

3 years ago
Staged: https://hg.mozilla.org/webtools/telemetry-experiment-server/rev/5448d3fa18f0

QA instructions:

Test using FF35.0b4 which should be built today.
Change these prefs:
* experiments.manifest.cert.checkAttributes;false
* experiments.manifest.uri replace telemetry-experiment.cdn.mozilla.net with telemetry-experiment-dev.allizom.org
* Use https://wiki.mozilla.org/QA/Telemetry/BrowserConsoleCommands to force-refresh the experiments
* Run the following command to see what experiment branch you are in: Experiments.instance()._getActiveExperiment.branch
** if you are in the "control" group, the pref dom.ipc.plugins.flash.disable-protected-mode should be false
** if you are in the "experiment" group, the pref should be true
The branch should be random 50/50 split. If you want to re-test to try and get into the other branch, close Firefox and delete <profile>/experiments.json and relaunch/force-refresh
Flags: needinfo?(spolk)
Flags: needinfo?(mozillamarcia.knous)
(Assignee)

Comment 4

3 years ago
Deployed in bug 1112677
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Depends on: 1112677
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Flags: needinfo?(spolk)
Flags: needinfo?(mozillamarcia.knous)
You need to log in before you can comment on or make changes to this bug.