Closed Bug 1110235 Opened 5 years ago Closed 5 years ago

Clicking on the header region of the search dropdown should trigger a search with the default engine

Categories

(Firefox :: Search, defect)

36 Branch
x86
All
defect
Not set
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 37
Iteration:
37.2
Tracking Status
firefox34 --- wontfix
firefox35 --- verified
firefox36 --- verified
firefox37 --- verified

People

(Reporter: phlsa, Assigned: Felipe)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

We observed some people trying to click that region (the header saying »Yahoo Search«) to initiate a search. We should make that possible.

Also, Cmd-Click should open the search in a new tab, to be consistent.

We don't need any visual feedback here for the moment.
Would you be interested in taking this bug too? I'm asking mostly because I'm thinking you may want to register this differently on telemetry.
Flags: needinfo?(bwinton)
I could take a stab at it, while I wait for reviews…
(I make no promises about whether or not I'll get it done this iteration, though!  ;)
Assignee: nobody → bwinton
Status: NEW → ASSIGNED
Iteration: --- → 37.2
Points: --- → 2
Flags: needinfo?(bwinton) → qe-verify+
I'm gonna steal this one while Blake works on bug 1106432
Assignee: bwinton → felipc
Thanks Felipe!  :D
Attached patch PatchSplinter Review
Attachment #8538492 - Flags: review?(florian)
Comment on attachment 8538492 [details] [diff] [review]
Patch

Review of attachment 8538492 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/urlbarBindings.xml
@@ +1202,5 @@
>          let button = event.originalTarget;
> +        if (!button.engine)
> +          button = button.parentNode;
> +
> +        if (!button.engine)

Would this be cleaner?

        let engine = button.engine || button.parentNode.engine;
        if (!engine)
          return;
Attachment #8538492 - Flags: review?(florian) → review+
https://hg.mozilla.org/mozilla-central/rev/addf2aa154fb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Flags: firefox-backlog+
Comment on attachment 8538492 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: new search UI
[User impact if declined]: User research has shown that some users tried to click the panel header (which says "Yahoo Search") and expected it to be a clickable trigger to search.
[Describe test coverage new/current, TBPL]: tests for the new search UI are still to-do
[Risks and why]: very small risk, simple change
[String/UUID change made/needed]: none
Attachment #8538492 - Flags: approval-mozilla-aurora?
Comment on attachment 8538492 [details] [diff] [review]
Patch

Approval Request Comment
I think we should take this for 35 too, as it's very low risk, and can avoid user confusion (and missed searches).
Attachment #8538492 - Flags: approval-mozilla-beta?
Attachment #8538492 - Flags: approval-mozilla-beta?
Attachment #8538492 - Flags: approval-mozilla-beta+
Attachment #8538492 - Flags: approval-mozilla-aurora?
Attachment #8538492 - Flags: approval-mozilla-aurora+
Verified fixed on Firefox 35.0b6 (20141222200458) using Ubuntu 12.04 LTS 32-bit, Windows 8.1 64-bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Verified as fixed using Developer Edition 36.0a2 and Nightly 37.0a1 2014-01-05 under Ubuntu 12.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5.
Depends on: 1206702
You need to log in before you can comment on or make changes to this bug.