Closed
Bug 1110507
Opened 9 years ago
Closed 9 years ago
self-image can be cropped by being out of scroll (firefox embedded client)
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
backlog | Fx35+ |
People
(Reporter: dmosedale, Assigned: dmosedale)
References
Details
(Keywords: privacy, Whiteboard: [rooms])
Attachments
(2 files, 2 obsolete files)
230.08 KB,
image/png
|
Details | |
1.46 KB,
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1101378 +++ Now in theory, they should be able to guess this by virtue of visible scrollbars on the window, which appear to be there at least on OSX Yosemite using Nightly, and presumably also on Windows and Linux. I suspect there are still problems with the mobile situation, however. In any case, this is fragile, and it would be a better user experience to simply make it impossible for the user to put themselves in this situation. Some possibilities to investigate include position: fixed on the publisher image, and playing with max-height and overflow on the window. If position: fixed isn't good enough, we might be able to use a position: sticky polyfill, since that isn't yet implemented everywhere.
Assignee | ||
Updated•9 years ago
|
Summary: room-joiner self-image can be cropped by being out of scroll → self-image can be cropped by being out of scroll
Assignee | ||
Updated•9 years ago
|
backlog: --- → Fx35?
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
If it turns out to be hard to avoid overflow situations, another hack we might try is using a CSS transform to scale the image down to the size of the viewport once the window has gotten small enough that overflow is happening.
Updated•9 years ago
|
Attachment #8535280 -
Attachment is patch: false
Attachment #8535280 -
Attachment mime type: text/plain → image/png
Comment 3•9 years ago
|
||
Dan -- Is this only for the standalone? In irc Abr was discussing issues with desktop if the user pops out the self image and scales it to be smaller than the original. Is that a separate bug from this one?
backlog: Fx35? → Fx35+
Flags: needinfo?(dmose)
Assignee | ||
Comment 4•9 years ago
|
||
For both, for the reason ABR mentioned. The fixes will not be exactly the same, and they may (or may not) be interrelated. So whether or not this should be split into two bugs is something of a toss up. Whatever we do in terms of Bugzilla tracking, presumably we should attack desktop first, since that takes longer to get from "fixed code" to "in the hands of users".
Flags: needinfo?(dmose)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dmose
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Summary: self-image can be cropped by being out of scroll → self-image can be cropped by being out of scroll (firefox embedded client)
Assignee | ||
Updated•9 years ago
|
Whiteboard: [standalone][rooms] → [rooms]
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8537377 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8537381 -
Flags: review?(jaws)
Comment 7•9 years ago
|
||
Comment on attachment 8537381 [details] [diff] [review] fix loop self image cropping privacy issue in firefox embedded client Review of attachment 8537381 [details] [diff] [review]: ----------------------------------------------------------------- Overall, this is good, but it is likely that there will be other consumers of the chatbox. One way that we can target this change to only affect Loop is to do the following: 1) Within socialchat.xml (potentially the swapWindows function's detachChatbox callback), call chatbox.setAttribute("src", chatbox.src); 1b) We could also remove the attribute when the window is re-docked. It may be nice to keep it around at all times, but it wouldn't be necessary to do so. Your call. 2) In browser.css, update the selector to be #chat-window[src^="about:looppanel"]
Attachment #8537381 -
Flags: review?(jaws) → feedback+
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8537381 [details] [diff] [review] fix loop self image cropping privacy issue in firefox embedded client Review of attachment 8537381 [details] [diff] [review]: ----------------------------------------------------------------- An excellent option! As discussed in today's standup, I've got it incorporated into another patch, which is turning out to be non-trivial to test without losing some race. Given Shane's statement that he's ok with the other consumers of this being handled in another bug, and the high priority stuff that we'd like to get in this week for 35, I'd like to re-request review for this patch as is. I'll spin out a new bug with the more complex version.
Attachment #8537381 -
Flags: feedback+ → feedback?(jaws)
Updated•9 years ago
|
Attachment #8537381 -
Flags: feedback?(jaws) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8537381 -
Attachment is obsolete: true
Attachment #8538028 -
Flags: review?(jaws)
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8538028 [details] [diff] [review] Loop self-image can be cropped by scrolling out of view (privacy) Updated comments to point to spinoff bug 1112264 for landing. Carrying forward r=jaws.
Attachment #8538028 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 11•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/067eb4b0d851
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/067eb4b0d851
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•9 years ago
|
Iteration: --- → 37.1
You need to log in
before you can comment on or make changes to this bug.
Description
•