1110519 - Plugin updater goes to wrong plugin's "blocked" page

Status: RESOLVED DUPLICATE of bug 1129287

(Toolkit :: Add-ons Manager, defect)

Description

[Vi Vovan]

Firefox Developer (Aurora) 2014-12-11

In add-ons manager -> Plugins, Shockwave Flash 15.0.0.223 has the alert header "Shockwave Flash is known to be vulnerable and should be updated. Update Now". Clicking on the "Update Now" link takes one to https://blocklist.addons.mozilla.org/en-US/firefox/blocked/p80 - which is the page for "Java Plugin has been blocked for your protection"

In Firefox 34, the same link takes one to https://blocklist.addons.mozilla.org/en-US/firefox/blocked/p178, which is "Flash Player Plugin between 11.0 and 11.7.700.169 (click-to-play) has been blocked for your protection." - closer, but still the wrong version and no option to update.

Currently installed plugins:
(ask to activate:)
-OpenH264
-Java Platform SE
-Shockwave Flash
(never activate:)
-Adobe Acrobat
-AdobeAAMDetect
-Java Deployment Toolkit

Comment 1

[Vi Vovan]

Additional information. With a new profile, the alert above the individual plugin does not appear, instead only the header above all, "check to see if your plugins are up to date" appears (which takes one to the "plugin check & updates" page).

Reverting back to the previous user profile, even with all extensions disabled, the alert inside Flash plugin block itself "Shockwave Flash is known to be vulnerable and should be updated. Update Now" reappears.

Comment 2

[bugcon]

I'm seeing the same thing, running Flash 15.0.0.239, FF 34.0.5
https://i.imgur.com/8Mfeb8y.png

Takes you to:
https://blocklist.addons.mozilla.org/en-US/firefox/blocked/p178

Presume it should point to:
https://blocklist.addons.mozilla.org/en-US/firefox/blocked/p794

Comment 3

[bugcon]

Actually, scratch that, a link labeled "Update Now" should either start an update download or take me to a page where an update is available for download which https://blocklist.addons.mozilla.org/en-US/firefox/blocked/p794 does not have.

Comment 4

[bugcon]

This is probably better said in a seperate report but the Flash update process is really poor.

The Flash update button on https://www.mozilla.org/plugincheck/ takes you to:
https://www.adobe.com/go/getflashplayer which redirects you to...
https://get.adobe.com/flashplayer/ which by default ticks a box which installs:
"...the free McAfee Security Scan Plus utility to check the status of [your] PC security."
for a total size of "18.08 MB", untick the box and it drops to "17.2 MB" except when you start the download what you actually get is:
"install_flashplayer16x32_mssd_aaa_aih.exe"; a 1MB downloader which will then download the actual update.

This is painfully convoluted.

Ideally the Plugin Check page would detect my OS and offer (in my case) a direct download to:
http://download.macromedia.com/get/flashplayer/current/licensing/win/install_flash_player_16_plugin.exe

Or at least link to a page with direct download links:
https://www.adobe.com/products/flashplayer/distribution3.html

Comment 5

[Georg Fritzsche [:gfritzsche]]

In bug 873093 we added a infoURL field to the blocklist (at least for Flash and Java).
In bug 1038145 we started to use this in other parts of the plugin UI.

We should start to use it here too, if present.
Also, we may be picking up the wrong blocklist entry here (comment 2 looks like we're not hitting the newest applicable blocklist entry).

(The notes plugincheck don't really belong here)

Comment 6

[Georg Fritzsche [:gfritzsche]]

This looks like bug 1129287.