1110572 - We should check the existance of a listener in this._listeners instead of listeners

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Ben Hsu [:HoPang]]

This bug is an implementation defect in MobileConnectionService.js. Everytime before we notify a listener, we should check the existance of the listener in this._listeners, the array which records the current registered listeners, instead of listeners.

Comment 1

[Ben Hsu [:HoPang]]

Attachment: Check the existance of a listener in this._listeners.

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8535405 [details] [diff] [review]
Check the existance of a listener in this._listeners.

Review of attachment 8535405 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch, Ben!!
Please remember to add `r=edgar` in commit message. :)
Thank you.

Comment 3

[Ben Hsu [:HoPang]]

https://tbpl.mozilla.org/?tree=Try&rev=fe047389ad3a

Comment 4

[Ben Hsu [:HoPang]]

Attachment: Patch-1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/bea91a0b4dfb

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bea91a0b4dfb