1110615 - Fix inheriting problem for blobs

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Christoph Kerschbaumer [:ckerschb]]

Bug 1104623 is a regression hotfix for aurora, but in fact we need to change the securityManager bits to fix the root cause of this problem.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1110615_blobfix.patch

Jonas, let's review this one first and the I will rebase the patches in Bug 1087442 to make the rest work.
Applying this patch let's the test from baku (Bug 1104623) finish correctly. So you are right, this is the right way of fixing the problem.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8535410 [details] [diff] [review]
bug_1110615_blobfix.patch

Review of attachment 8535410 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Just to make sure everything works as expected:
   https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5b36a94cc7a0

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We should also check that the test in bug 1104623 still passes (leaks aside)

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Jonas Sicking (:sicking) from comment #4)
> We should also check that the test in bug 1104623 still passes (leaks aside)

Passes locally - also included the test-patch from Bug 1104623 when pushing to try.

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

Part of that pushlog:
  https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=2c906f995097

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

This pushlogs are confusing:
  https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=2e0a0c0d7685

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2c906f995097