Closed
Bug 1110639
Opened 10 years ago
Closed 9 years ago
Remove testAdons_installTheme
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(firefox35 fixed, firefox36 fixed, firefox37 fixed, firefox38 fixed, firefox-esr31 fixed)
People
(Reporter: mihaelav, Assigned: daniela.domnici)
References
Details
(Whiteboard: [sprint])
Attachments
(4 files, 2 obsolete files)
|
5.18 KB,
patch
|
AndreeaMatei
:
review+
|
Details | Diff | Splinter Review |
|
5.25 KB,
patch
|
mihaelav
:
review+
AndreeaMatei
:
review+
|
Details | Diff | Splinter Review |
|
5.36 KB,
patch
|
AndreeaMatei
:
review+
|
Details | Diff | Splinter Review |
|
5.50 KB,
patch
|
AndreeaMatei
:
review+
mihaelav
:
review+
|
Details | Diff | Splinter Review |
firefox/tests/functional/restartTests/testAddons_installTheme can be removed from our repo since it is already covered by the uninstallTheme one.
|
Assignee | |
Comment 1•10 years ago
|
||
Created patch for removing testInstallTheme
Attachment #8535492 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8535492 -
Flags: review?(andreea.matei)
|
Reporter | |
Updated•10 years ago
|
Attachment #8535492 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8535492 -
Flags: review?(andreea.matei)
Attachment #8535492 -
Flags: review+
Attachment #8535492 -
Flags: checkin?(andreea.matei)
|
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8535492 [details] [diff] [review] patch_V1 Review of attachment 8535492 [details] [diff] [review]: ----------------------------------------------------------------- The patch doesn't apply
Attachment #8535492 -
Flags: review-
Attachment #8535492 -
Flags: review+
Attachment #8535492 -
Flags: checkin?(andreea.matei)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Updated patch :)
Attachment #8535492 -
Attachment is obsolete: true
Attachment #8535610 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8535610 -
Flags: review?(andreea.matei)
|
|
Reporter | |
Comment 4•10 years ago
|
||
Comment on attachment 8535610 [details] [diff] [review] patch_V2 Review of attachment 8535610 [details] [diff] [review]: ----------------------------------------------------------------- It applies now, thanks.
Attachment #8535610 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8535610 -
Flags: review?(andreea.matei)
Attachment #8535610 -
Flags: review+
Attachment #8535610 -
Flags: checkin?(andreea.matei)
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8535610 [details] [diff] [review] patch_V2 Review of attachment 8535610 [details] [diff] [review]: ----------------------------------------------------------------- Sorry, we're doing a lot of changes to the restart tests these days. Not applying once again. Please also check if the uninstall theme test is on all branches, to know if we can remove this one on all. Please mark the affected branches with the flags.
Attachment #8535610 -
Flags: checkin?(andreea.matei)
|
|
Assignee | |
Updated•10 years ago
|
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
status-firefox-esr31:
--- → affected
|
|
Assignee | |
Comment 6•10 years ago
|
||
Updated patch
Attachment #8535610 -
Attachment is obsolete: true
Attachment #8540162 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8540162 -
Flags: review?(andreea.matei)
|
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8540162 [details] [diff] [review] patch_V3 Review of attachment 8540162 [details] [diff] [review]: ----------------------------------------------------------------- Removed: http://hg.mozilla.org/qa/mozmill-tests/rev/49dee95951d6 (default)
Attachment #8540162 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8540162 -
Flags: review?(andreea.matei)
Attachment #8540162 -
Flags: review+
|
|
||
Updated•10 years ago
|
|
|
Assignee | |
Comment 8•9 years ago
|
||
Created a new patch for beta branch. The removed test does not influence the other tests.Here are the results: http://mozmill-crowd.blargon7.com/#/functional/report/dd0cbbf05a3aab4a7676502a8638927c
Attachment #8551243 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8551243 -
Flags: review?(andreea.matei)
|
|
Reporter | |
Comment 9•9 years ago
|
||
Comment on attachment 8551243 [details] [diff] [review] patch_V1_beta Review of attachment 8551243 [details] [diff] [review]: ----------------------------------------------------------------- The patch fails to apply for me on mozilla-beta: applying ../RemoveTestInstallTheme.patch patching file firefox/tests/functional/restartTests/manifest.ini Hunk #1 FAILED at 0 1 out of 1 hunks FAILED -- saving rejects to file firefox/tests/functional/restartTests/manifest.ini.rej abort: patch failed to apply
Attachment #8551243 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8551243 -
Flags: review?(andreea.matei)
Attachment #8551243 -
Flags: review-
|
|
Reporter | |
Comment 10•9 years ago
|
||
Comment on attachment 8551243 [details] [diff] [review] patch_V1_beta Review of attachment 8551243 [details] [diff] [review]: ----------------------------------------------------------------- Please ignore previous comment, the patch applies correctly.
Attachment #8551243 -
Flags: review- → review+
|
|
Reporter | |
Updated•9 years ago
|
Attachment #8551243 -
Flags: review?(andreea.matei)
|
|
||
Comment 11•9 years ago
|
||
Comment on attachment 8551243 [details] [diff] [review] patch_V1_beta Review of attachment 8551243 [details] [diff] [review]: ----------------------------------------------------------------- http://hg.mozilla.org/qa/mozmill-tests/rev/76a43120f67d (beta)
Attachment #8551243 -
Flags: review?(andreea.matei) → review+
|
|
||
Updated•9 years ago
|
Assignee: nobody → daniela.domnici
Status: NEW → ASSIGNED
status-firefox34:
affected → ---
status-firefox38:
--- → fixed
Whiteboard: [sprint]
|
|
Assignee | |
Comment 12•9 years ago
|
||
Created a new patch for release branch. The removed test does not influence the other tests.Here are the results: http://mozmill-crowd.blargon7.com/#/functional/report/dd0cbbf05a3aab4a7676502a86b2e6ef
Attachment #8552286 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8552286 -
Flags: review?(andreea.matei)
|
|
||
Updated•9 years ago
|
Attachment #8552286 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8552286 -
Flags: review?(andreea.matei)
Attachment #8552286 -
Flags: review+
|
|
||
Comment 13•9 years ago
|
||
https://hg.mozilla.org/qa/mozmill-tests/rev/2ab92f4fd108 (release)
|
|
Assignee | |
Comment 14•9 years ago
|
||
Created a new patch for esr-31 branch. The removed test does not influence the other tests.Here are the results: http://mozmill-crowd.blargon7.com/#/functional/report/1fce32f68777a8fb1815d1dc0219bb6c
Attachment #8553685 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8553685 -
Flags: review?(andreea.matei)
|
|
Reporter | |
Updated•9 years ago
|
Attachment #8553685 -
Flags: review?(mihaela.velimiroviciu) → review+
|
|
||
Comment 15•9 years ago
|
||
Comment on attachment 8553685 [details] [diff] [review] patch_V1_esr31 Review of attachment 8553685 [details] [diff] [review]: ----------------------------------------------------------------- http://hg.mozilla.org/qa/mozmill-tests/rev/1e890bf0ed80 (esr31)
Attachment #8553685 -
Flags: review?(andreea.matei) → review+
|
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•