1110640 - [Flame][Settings]Some last button has bottom line, and some last check box does not have bottom line.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Lance（leave from Mozilla）]

Attachment: logcat_1521.txt

[1.Description]:
[Flame 2.1 & 2.2][Settings]Some last button has bottom line, and some last check box does not have bottom line in Settings.
Found time:15:21
See attachment: logcat_1521.txt, Button.png, Check_box.png.

[2.Testing Steps]: 
Premise: Not log in Firefox account in Settings.
1.Launch Settings.
2.Tap "Find My Device".
3.Press back key, then tap "USB storage"/"Themes".

[3.Expected Result]: 
2.There is no line under "Create account or sign in" button.
3.There is a line under "USB mass Storage(UMS)"/"Test theme 2".

[4.Actual Result]: 
2.There is a line under "Create account or sign in" button.
3.There is no line under "USB mass Storage(UMS)"/"Test theme 2".

[5.Reproduction build]: 
Flame 2.1 version:
Gaia-Rev        97873dca486abf4162a3345e71b375806937bdec
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-2g34_v2_1/rev/9faa165ac85d
Build-ID        20141211001204
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141211.034507
FW-Date         Thu Dec 11 03:45:22 EST 2014
Bootloader      L1TC00011880

Flame 2.2 version:
Gaia-Rev        1a956437210d2b16988d2ddbf40c9a38d8474435
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/d92db71d4e67
Build-ID        20141211040208
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141211.074025
FW-Date         Thu Dec 11 07:40:36 EST 2014
Bootloader      L1TC00011880

[6.Reproduction Frequency]: 
Always Recurrence,5/5
TCID: 11752

Comment 1

[Lance（leave from Mozilla）]

Attachment: Button.png

Comment 2

[Lance（leave from Mozilla）]

Attachment: Check_box.png

Comment 3

[Mike Lien[:mlien]]

Refer to test case ID 11752, set blocking-b2g: 2.2?

Comment 4

[howie [:howie]]

Hi Mike, the test case ID 11752 is Mozilla test case? And does it blocks any certification? thanks

Comment 5

[Mike Lien[:mlien]]

Yes, 11752 is moztrap case ID but this doesn't block any certification

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: minor defect, -'ing.

Comment 7

[Lance（leave from Mozilla）]

This bug has been verified to fail on Flame 2.1, 2.2 and 3.0.

Issue steps:
Premise: Not log in Firefox account in Settings.
1.Launch Settings.
2.Tap "Find My Device".
3.Press back key, then tap "USB storage"/"Themes".

Expected Result: 
2.There is no line under "Create account or sign in" button.
3.There is a line under "USB mass Storage(UMS)"/"Test theme 2".

Actual Result: 
2.There is a line under "Create account or sign in" button.
3.There is no line under "USB mass Storage(UMS)"/"Test theme 2".

Reproducing rate: 5/5

Flame 2.1 version:
Build ID               20150209001212
Gaia Revision          4a14bb118d55f3d15293c2ff55b7f29f9b0bfcdb
Gaia Date              2015-02-06 20:37:32
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/6cbe28d0bb8c
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150209.035242
Firmware Date          Mon Feb  9 03:52:53 EST 2015
Bootloader             L1TC000118D0

Flame 2.2 version:
Build ID               20150209002504
Gaia Revision          e827781324cbde91d2434b388f5dead3303a85ee
Gaia Date              2015-02-06 20:54:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0552759956d3
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150209.040038
Firmware Date          Mon Feb  9 04:00:51 EST 2015
Bootloader             L1TC000118D0

Flame 3.0 version:
Build ID               20150209010211
Gaia Revision          0d7b35f23402c4cb29bca6b98280fec48a196dec
Gaia Date              2015-02-08 20:44:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3436787a82d0
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150209.045655
Firmware Date          Mon Feb  9 04:57:06 EST 2015
Bootloader             L1TC000118D0

Comment 8

[William Hsu [:whsu]]

Hi, Lance,

Thanks for your help!
This is a minor defect. DM or EPM will assign developer to fix this bug after they solve the blockers.
So, please be patient. :)

Comment 9

[Scott Wu [:scottwu]]

I'm looking into this issue, but I'm not sure what the rules are for having a bottom line. In what situations should there be one, and in what situation shouldn't?

Thanks!

Comment 10

[Tiffanie Shakespeare [:tif]]

NI to Hung as he is working on a list component. It should definitely be consistent but the question is to have the last line or not.

Thanks for pinging the UX team!

Comment 11

[Hung Nguyen]

Hi! 

The screens attached to this bug are correct. There should not be a divider for the last item in the list (whether it be a button, radio button, etc). 

Thanks!

Comment 12

[Alexey Yakimov]

Hi Hung, I guess there is some confusion introduced by your latest comment. From one point of view you mentioned that there should not be a divider for the last element in the list. From the other hand you said that the screens are correct, but for Check_box.png there is a divider below the checkbox and this screen is marked as correct which seems to be contradictory. 

Could you please clartify your point? I guess that the correct behavior is absense of a divider below the last item, but it is worth to double check with you.

Thanks.

Comment 13

[Hung Nguyen]

Hey Alexey

Sorry there is typo in my comment. I meant to say the screens are "incorrect" and there should not be a divider for the last item in the list. 

Hope this clarifies things and please let me know if you need anything else. 

Cheers!

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] ruvsmirnov:bug-1110640-bottom-line-in-settings-points > mozilla-b2g:master

Comment 15

[Alexey Yakimov]

Comment on attachment 8695253 [details] [review]
[gaia] ruvsmirnov:bug-1110640-bottom-line-in-settings-points > mozilla-b2g:master

Evelyn, could you please review this simple patch or ask someone else to do it. Thanks!

Comment 16

[[e-mail]]

Comment on attachment 8695253 [details] [review]
[gaia] ruvsmirnov:bug-1110640-bottom-line-in-settings-points > mozilla-b2g:master

Works great, thanks!

Comment 17

[[e-mail]]

merged to master https://github.com/mozilla-b2g/gaia/commit/8faea23026246dea059fa7b9423ccb08fb8f5b72

Comment 18

[Lance（leave from Mozilla）]

This bug has been verified as "Pass" on the latest build of Flame KK master (512mb) and Aries KK master by the STR in comment 0.
Actual result: 
Step2.There is no line under "Create account or sign in" button.
Occurrence rate: 0/10.

Device: Flame KK master 512mb (Pass)
Build ID               20151217150205
Gaia Revision          140f6ee998b07b354d1841fed902056179c90100
Gaia Date              2015-12-16 23:09:21
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f143af51f6e35932927b8ccac2509facbbe7b539
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151217.182817
Firmware Date          Thu Dec 17 18:28:30 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151217120654
Gaia Revision          140f6ee998b07b354d1841fed902056179c90100
Gaia Date              2015-12-16 23:09:21
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0711218a018d912036f7d3be2ae2649e213cfb85
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151217.112618
Firmware Date          Thu Dec 17 11:26:26 UTC 2015
Bootloader             s1