1110673 - [System] When disabling/enabling auto-brightness, the previous brightness is not restored

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. open Settings > Display panel
2. check that brightness auto-adjust is enabled
3. disable it
4. set the brightness setting to something different (maximum for example)
5. enable auto-adjust
=> the brightness does not change until it changes to a different enough value.

This is a regression from bug 1042673.
Note that even before bug 1042673 the same symptom could happen because of a platform issue (see bug 989281 for more information), but bug 1042673 made it more apparent by adding a gaia bug on top of this issue.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] julienw:1110673-fix-regression-with-previousLux to mozilla-b2g:master

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8535528 [details] [review]
[PullReq] julienw:1110673-fix-regression-with-previousLux to mozilla-b2g:master

nit: s/null/undefined/ since the property point to a number?

Comment 3

[Julien Wajsberg [:julienw]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #2)
> Comment on attachment 8535528 [details] [review]
> [PullReq] julienw:1110673-fix-regression-with-previousLux to
> mozilla-b2g:master
> 
> nit: s/null/undefined/ since the property point to a number?

Usually I like to think of "undefined" as "I haven't set a value to this variable yet, but "null" is "I set a value to this variable that is not a real value". I don't take the variable type into account.

That said, I don't really mind, I can do this change.

Comment 4

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/bed490d776129dbf7617bcf97941fbf2f9015996