1110700 - Entering fullscreen mode and following a particular series of steps can cause the Hello Panel to become blank on Windows only

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect, P4)

Description

[Vasilica Tamas, QA [:vtamas]]

Reproducible on: 
Firefox 35 Beta 3 and Latest Nightly on Windows 7 x64 

STR
1.Launch Firefox with a clean profile.
2.Click on Hello Button from toolbar.
3.Click Get Started button.
4.Enter and Exit the Fullscreen Mode (F11). 
5.Click on Hello Button icon (See http://i.imgur.com/JpYsfLM.png)
6.Repeat Step 4 again.
7.Repeat Step 5 again (See http://i.imgur.com/GsCsXYe.png)

ER
There should be no UI issues while changing between fullscreen and normal mode.

AR
Hello Button Doorhanger is completely blank and unusable.

Additional notes:
 - This issue is reproducible on Firefox 35 Beta 3 (20141211142524) and Latest Firefox 37.0a1 (2014-12-11) using Windows 7 x64.
 - This issue is not reproducible on Ubuntu 14.04 x86 and Mac OSX 10.9.5
 - There are no errors in Browser Console when this issue occurs

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Reproducible, though other variants of STR don't seem to hit the same issue.  If the panel is open when you switch into full-screen, it will go blank, but closing it and reopening fixes it.

It appears related to some sort of memory of position/size/etc.  If I repeat step 5 (i.e. open panel, close panel, open panel again) the size is normal.  Step 6/7 (f11 twice, open hello) will then put you back at step 5 (i.e. the panel is enlarged, but not blank).  Once you get to step 7 (fully blank panel), you have to restart the browser to reset it.  Anything along the way that resets you to a normal panel will avoid it, and you have to enter and leave fullscreen twice, opening the panel only exactly once inbetween.

Comment 2

[Maire Reavy [:mreavy]]

This is an unusual sequence of events (most users are unlikely to hit this), but it's bad that we can't recover without restart.  So I'd like to fix this ASAP and see if we can get it into Fx35.

Comment 3

[Romain Gauthier [:tOkeshu]]

I can't reproduce it on Ubuntu 14.04.

Comment 4

[Maire Reavy [:mreavy]]

Romain -- Did you follow the exact STR from Comment 0?  I found I had to follow them exactly, or I couldn't reproduce.

Comment 5

[Romain Gauthier [:tOkeshu]]

Maire -- Yes I confirm, I started over with a fresh profile as well.

Comment 6

[Vasilica Tamas, QA [:vtamas]]

As mentioned in Comment 0, this issue is *not* reproducible on Ubuntu 14.04 x86 and Mac OSX 10.9.5. Only Windows is affected.

Comment 7

[Maire Reavy [:mreavy]]

ok, thanks.  Updating the title to reflect what we're seeing.

Comment 8

[Paul Silaghi, QA [:pauly]]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #2)
> This is an unusual sequence of events (most users are unlikely to hit this),
I only need to enter/exit fullscren once to see http://i.imgur.com/JpYsfLM.png

Comment 9

[Maire Reavy [:mreavy]]

(In reply to Paul Silaghi, QA [:pauly] from comment #8)
> (In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #2)
> > This is an unusual sequence of events (most users are unlikely to hit this),
> I only need to enter/exit fullscren once to see
> http://i.imgur.com/JpYsfLM.png

I agree this is ugly, and I *really* want to fix it for Fx35, but I wouldn't block the release for this.

Comment 10

[Maire Reavy [:mreavy]]

FYI: If I open the panel a second time in full screen mode, the extra white space at the bottom goes away for me.

Comment 11

[u279076]

[Tracking Requested - why for this release]: nominated to track since this is a Loop-35 blocker.

Comment 12

[Maire Reavy [:mreavy]]

Anthony -- Which part of this do you consider a blocker?  The white space at the bottom that Pauly mentions in Comment 8, or the 7-part STR from Vasilica in Comment 0?

Comment 13

[u279076]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #12)
> Anthony -- Which part of this do you consider a blocker?  The white space at
> the bottom that Pauly mentions in Comment 8, or the 7-part STR from Vasilica
> in Comment 0?

I merely called this a blocker since you flagged it as such in comment 2. In hindsight I'd be okay to ship 35 with this assuming the Beta tag is still in place.

Comment 14

[Maire Reavy [:mreavy]]

Given the STRs to reproduce and that we are keeping the Beta tag on for Fx35, I'm removing it from tracking.  My recommendation is to keep the Beta tag on for a few releases (until we have a full UI-review & signoff and are convinced that call completion rates and call quality are consistently good).

Comment 15

[Maire Reavy [:mreavy]]

I very much want to get this fixed and landed ASAP -- and uplifted to Fx36 if possible

Comment 16

[Jared Wein [:jaws] (please needinfo? me)]

Taking after discussion from today's Loop standup meeting.

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

If the panel is open when fullscreen is requested, the boxObject for the iframe gets reported as h=100, w=0 the next time the panel is opened (at Social.jsm:445).

Could toggling window.fullScreen for the main browser window be affecting the iframe inside of the PanelFrame, and thus making the embedded iframe lose its layout temporarily?

Comment 18

[Neil Deakin]

Is the panel being hidden, or the frame otherwise being destroyed?

Does the panel have a transition? Does disabling it make the bug go away?

Comment 19

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Neil Deakin from comment #18)
> Is the panel being hidden, or the frame otherwise being destroyed?

In Social.jsm, there is a DynamicResizeWatcher that has a mutation observer that is supposed to resize the panel to the size of the iframe if any of {attributes, characterData, childList, subtree} changes. I disabled the DynamicResizeWatcher and the bug still happens so I don't think it is due to that.

I can reproduce this bug also with the "Share this page" button in the toolbar, which also uses PanelFrame.jsm. Shane, do you see anything in PanelFrame.jsm that could be causing this?

> Does the panel have a transition? Does disabling it make the bug go away?

The panel has a transition. Setting animate="false" on the panel doesn't fix the bug.

Comment 20

[Shane Caraveo (:mixedpuppy)]

One thing in PanelFrame.jsm that bothers me is the callback happening before the panel being opened.  IMO the callback should happen after, possibly even from initFrameShow.  Not sure that would cause any issue though.

Comment 21

[Jared Wein [:jaws] (please needinfo? me)]

Oddly enough, I can't reproduce this bug on Windows 8.1. I tried with builds from 2015-01-01 to 2015-01-22 and binary searched in between as well.

Comment 22

[Jared Wein [:jaws] (please needinfo? me)]

I spent some more time today on this bug and haven't been able to make any progress on it. I tried hiding the popup on the "fullscreen" event and also stopping the dynamicResizer earlier in popuphiding.

Neil, do you think you could help me debug this?

Comment 23

[Maire Reavy [:mreavy]]

Hi Shell -- I'm just cleaning up some old Loop bugs (marked "blocking-loop Fx36+").  Can you bring this one up at the next triage meeting?  Do we still want to fix this bug asap (and consider uplifting it)? If so (with Jared focused on the UI Tour bugs), does it make sense to reassign it?  Thanks.

Comment 24

[Jared Wein [:jaws] (please needinfo? me)]

Closing old needinfo request...

Comment 25

[Ada [:adalucinet]]

On the affected versions [1], this issue here is easier to reproduce: just click on the Hello button and hit F11 (enter fullscreen); and still, only a browser restart will make this issue go away.

Screenshot: https://goo.gl/RSBlnL

[1] Affected versions: 44.0RC build 3 (Build ID: 20160123151951), 45.0b2 (Build ID: 20160201143558) and latest Nightly 47.0a1 (from 2016-02-02), e10s enabled/disabled 

Unaffected versions: latest Aurora 46.0a2 (from 2016-02-02), e10s enabled/disabled - which is very weird imho!

Affected platforms: Windows 7 64-bit - 2 different machines
Unaffected platforms: Ubuntu 14.04 32-bit, Mac OS X 10.9.5, Windows 10 32-bit, Windows 10 64-bit

Also updating the tracking flags accordingly.

Comment 26

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.