1110759 - Remove various non-standard things from tests

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tom S [:evilpie]]

While working on different iterations of my patch for bug 783829, I identified various tests that could be updated. I should probably not waste those patches.

Comment 1

[Tom S [:evilpie]]

Attachment: fix-browser-tests

Comment 2

[Tom S [:evilpie]]

Attachment: fix-tests

Comment 3

[Tom S [:evilpie]]

Attachment: Cleanup FormHistory a bit

If you look athte whole file it looks like it expects the object for "for each" to have a length property. So it's probably just an array.

Comment 4

[Tom S [:evilpie]]

Attachment: Remove Iterator() from some tests

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8543545 [details] [diff] [review]
Remove Iterator() from some tests

> function runNextSpinTest() {
>-  try {
>-    var [index, test] = spinTests.next();
>-    test();
>-  } catch(e) {
>-    if (e == StopIteration) {
>-      SimpleTest.finish();
>-      return; // We're all done
>-    }
>-    throw e;
>+  var test = spinTests.shift();
>+  if (!test) {
>+    SimpleTest.finish();
>+    return;
>   }
>+  SimpleTest.executeSoon(test);
I don't understand why you need asynchronousness  here.
Doesn't the old code just run sync or am I missing something.


Please fix or explain and re-ask review.

Comment 6

[Tom S [:evilpie]]

Attachment: v2 - Remove Iterator() from some tests

Fixed.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3179d05230b
https://hg.mozilla.org/mozilla-central/rev/6429d270c004