Closed Bug 1110759 Opened 5 years ago Closed 5 years ago

Remove various non-standard things from tests

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 37

People

(Reporter: evilpie, Assigned: evilpie)

Details

Attachments

(2 files, 3 obsolete files)

While working on different iterations of my patch for bug 783829, I identified various tests that could be updated. I should probably not waste those patches.
Attached patch fix-browser-tests (obsolete) — Splinter Review
Attached patch fix-tests (obsolete) — Splinter Review
Attachment #8535590 - Attachment is patch: true
Attachment #8535591 - Attachment is patch: true
If you look athte whole file it looks like it expects the object for "for each" to have a length property. So it's probably just an array.
Attachment #8543544 - Flags: review?(mhammond)
Attachment #8543545 - Flags: review?(bugs)
Attachment #8535590 - Attachment is obsolete: true
Attachment #8535591 - Attachment is obsolete: true
Attachment #8543544 - Flags: review?(mhammond) → review+
Comment on attachment 8543545 [details] [diff] [review]
Remove Iterator() from some tests

> function runNextSpinTest() {
>-  try {
>-    var [index, test] = spinTests.next();
>-    test();
>-  } catch(e) {
>-    if (e == StopIteration) {
>-      SimpleTest.finish();
>-      return; // We're all done
>-    }
>-    throw e;
>+  var test = spinTests.shift();
>+  if (!test) {
>+    SimpleTest.finish();
>+    return;
>   }
>+  SimpleTest.executeSoon(test);
I don't understand why you need asynchronousness  here.
Doesn't the old code just run sync or am I missing something.


Please fix or explain and re-ask review.
Attachment #8543545 - Flags: review?(bugs) → review-
Fixed.
Attachment #8543545 - Attachment is obsolete: true
Attachment #8545974 - Flags: review?(bugs)
Attachment #8545974 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c3179d05230b
https://hg.mozilla.org/mozilla-central/rev/6429d270c004
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
You need to log in before you can comment on or make changes to this bug.