1110817 - [mozdevice] - adb_android.is_device_ready - UnboundLocalError: local variable 'data' referenced before assignment

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: adb_android_is_device_ready.patch

In is_device_ready <http://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozdevice/mozdevice/adb_android.py#75> it is possible for 'data' to not be initialized before the not success debug statement if get_state never returns 'device' or if the pm_list_cmd returns an error string. This patch changes the variable name to 'failure' and makes sure to initialize it and set it everywhere success is set to False.

Comment 1

[William Lachance (:wlach)]

Comment on attachment 8535622 [details] [diff] [review]
adb_android_is_device_ready.patch

Review of attachment 8535622 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 2

[Bob Clary [:bc] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/224479de335a

I had tried a try run but could not get android tests to run. I finally gave up and pushed anyway. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4c0312072512

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/224479de335a