1110863 - Send welcome email task broken

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Jannis Leidel [:jezdez]]

What did you do?
================
The fix to bug 1104864 also introduce a regression to sending the welcome email related to database transaction handling.

What happened?
==============
The patch to bug 1104864 removed committing the database transaction at the end of the signup flow was removed and led to a the Celery task that sends welcome email to not find the user objects in the database.

What should have happened?
==========================
It should still work.

Is there anything else we should know?
======================================
Django 1.4 strikes again.

Comment 1

[Jannis Leidel [:jezdez]]

I looked through the error emails, this is the code to send out the welcome emails for those users that were impacted by the bug:

```
    from kuma.users.tasks import send_welcome_email

    users_to_fix = (
        (183433, 'en-US'),
        (183497, 'vi'),
        (183519, 'en-US'),
        (183535, 'en-US'),
        (183539, 'en-US'),
        (183565, 'en-US'),
        (183575, 'vi'),
        (183629, 'en-US'),
        (183653, 'en-US'),
        (183655, 'en-US'),
        (183729, 'en-US'),
        (183779, 'en-US'),
        (183811, 'en-US'),
        (183837, 'id'),
        (183839, 'pt-BR'),
    )

    for user_id, locale in users_to_fix:
        send_welcome_email.delay(user_id, locale)
```

Comment 2

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/5e7d7b6e1f6f2c83bfa7f2c8dd40a76b4ef9242c
Fix bug 1110863 - Commit the db transaction before completing signup.

This is a regression from bug 1104864 and relateds to the abysymal
behavior of the Django 1.4 transaction middleware. Celery is just a
pawn in its game. God damnit.

https://github.com/mozilla/kuma/commit/2eb98894e8a5307f1989ed7805c8121bbaf9f1f6
Merge pull request #2950 from jezdez/bug1110863

Fix bug 1110863 - Commit the db transaction before completing signup.

Comment 3

[Jannis Leidel [:jezdez]]

I've sent the emails out to the users that missed the email.

Comment 4

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/37b5fa746b394c3abee84ccf3bb9b2c3e0070ed4
bug 1110863 - remove username from deletion log

https://github.com/mozilla/kuma/commit/2ea1e42080b4310a5aead504750caef2f1c299a0
Merge pull request #2951 from groovecoder/remove-deleter-usernames-1109994

bug 1110863 - remove username from deletion log

Comment 5

[Luke Crouch [:groovecoder]]

Note: the previous commit comment should have referenced https://bugzilla.mozilla.org/show_bug.cgi?id=1109994.