The default bug view has changed. See this FAQ.

Google login popup gives no context

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Provider: GData
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rkent, Assigned: Fallen)

Tracking

unspecified
4.0.0.1
x86_64
Windows 8.1

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

2 years ago
I assume that the latest version of the GData provider is what is now giving a popup window "Enter name and password for rkentjames@gmail.com"

This window has no hint as to why it is being requested. I can only assume that it has something to do with this addon. It is really not acceptable to just have a screen popup asking for credentials, without any hint as to why they are wanted.
(Assignee)

Comment 1

2 years ago
This is no different with the Filelink OAuth window when it appears, but that doesn't mean it shouldn't be fixed. I guess I could add a <description> at the top of the browser window being shown describing the circumstances.

Comment 2

2 years ago
A description would be an excellent addition, also to help debug the multiple master password dialog boxes irritating problem...
(Assignee)

Comment 3

2 years ago
Created attachment 8543497 [details] [diff] [review]
Fix - v1
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8543497 - Flags: review?(mohit.kanwal)
(Assignee)

Comment 4

2 years ago
Created attachment 8543498 [details] [diff] [review]
Fix - v1
Attachment #8543497 - Attachment is obsolete: true
Attachment #8543497 - Flags: review?(mohit.kanwal)
Attachment #8543498 - Flags: review?(mohit.kanwal)
(Assignee)

Comment 5

2 years ago
Comment on attachment 8543498 [details] [diff] [review]
Fix - v1

Mohit, I'm moving around the reviews a bit so not all of the requests are on your shoulders :)
Attachment #8543498 - Flags: review?(mohit.kanwal) → review?(bv1578)
(Assignee)

Comment 6

2 years ago
Created attachment 8552398 [details] [diff] [review]
Fix - v2

Oh and I needed to debitrot the patch
Attachment #8543498 - Attachment is obsolete: true
Attachment #8543498 - Flags: review?(bv1578)
Attachment #8552398 - Flags: review?(bv1578)
(Assignee)

Comment 7

2 years ago
Created attachment 8552421 [details] [diff] [review]
Fix - v2
Attachment #8552398 - Attachment is obsolete: true
Attachment #8552398 - Flags: review?(bv1578)
Attachment #8552421 - Flags: review?(bv1578)
(Assignee)

Updated

2 years ago
Blocks: 1117541

Comment 8

2 years ago
Comment on attachment 8552421 [details] [diff] [review]
Fix - v2

Review of attachment 8552421 [details] [diff] [review]:
-----------------------------------------------------------------

It works fine and the message in description seems complete for the use.

I would add only a bit of margin on the bottom of the #dialogMessage element so that the message would appear vertical centered in the box.

::: calendar/locales/en-US/chrome/calendar/providers/gdata/gdata.properties
@@ +47,5 @@
>  # LOCALIZATION NOTE (syncStatus):
>  # %1$S = The name of the calendar that is being synchronized
>  syncStatus=Synchronizing Calendar %1$S
> +
> +# %1$S - The session id (email) used for authentication

Here you could add the LOCALIZATION NOTE header just to make the block the same as the other in the file.
Attachment #8552421 - Flags: review?(bv1578) → review+
(Assignee)

Comment 9

2 years ago
Created attachment 8553683 [details] [diff] [review]
Fix - v3

Thanks, all comments taken care of :)
Attachment #8552421 - Attachment is obsolete: true
Attachment #8553683 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Target Milestone: --- → 4.0
(Assignee)

Comment 10

2 years ago
Pushed to comm-central changeset 84fa89be5232
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1136582
You need to log in before you can comment on or make changes to this bug.