I assume that the latest version of the GData provider is what is now giving a popup window "Enter name and password for email@example.com" This window has no hint as to why it is being requested. I can only assume that it has something to do with this addon. It is really not acceptable to just have a screen popup asking for credentials, without any hint as to why they are wanted.
This is no different with the Filelink OAuth window when it appears, but that doesn't mean it shouldn't be fixed. I guess I could add a <description> at the top of the browser window being shown describing the circumstances.
A description would be an excellent addition, also to help debug the multiple master password dialog boxes irritating problem...
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8543497 - Flags: review?(mohit.kanwal)
Comment on attachment 8543498 [details] [diff] [review] Fix - v1 Mohit, I'm moving around the reviews a bit so not all of the requests are on your shoulders :)
Attachment #8543498 - Flags: review?(mohit.kanwal) → review?(bv1578)
Oh and I needed to debitrot the patch
Comment on attachment 8552421 [details] [diff] [review] Fix - v2 Review of attachment 8552421 [details] [diff] [review]: ----------------------------------------------------------------- It works fine and the message in description seems complete for the use. I would add only a bit of margin on the bottom of the #dialogMessage element so that the message would appear vertical centered in the box. ::: calendar/locales/en-US/chrome/calendar/providers/gdata/gdata.properties @@ +47,5 @@ > # LOCALIZATION NOTE (syncStatus): > # %1$S = The name of the calendar that is being synchronized > syncStatus=Synchronizing Calendar %1$S > + > +# %1$S - The session id (email) used for authentication Here you could add the LOCALIZATION NOTE header just to make the block the same as the other in the file.
Attachment #8552421 - Flags: review?(bv1578) → review+
Thanks, all comments taken care of :)
Pushed to comm-central changeset 84fa89be5232
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.