[Email] Password field can not utilize Text Selection or Cut/Copy Paste functionality

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: onelson, Assigned: jrburke)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.2 affected)

Details

(Whiteboard: [2.2-Daily-Testing], URL)

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8535673 [details]
logcat_20141212_0912.txt

Description:
When a user attempts to make a text selection on a password field within manual selection, they will observe that they cannot make a selection on the text. Alongside this, they may not perform any Cut/Copy/Paste operations aside from an atypical case of paste:
* If field currently has text when accessing, tapping the blue carat will allow the user to paste into the text field. (marked in repro step #9)
   
Repro Steps:
1) Update a Flame device to BuildID: 20141212040206
2) Open 'Email' app.
3) Input a name and email address and navigate to 'Manual Setup'.
4) Locate 'Password' field and input text.
**5) Hold tap on text field in attempt to highlight text.
6) Tap on 'Username' field to remove focus from password.
7) Copy text to clipboard via Cut/Copy/Paste menu.
8) While 'Password' has text input, tap into field and tap blue carat that appears.
*9) Observe Paste operation accessibility.
  
Actual:
** User may not make selection text within 'Password' field.
  
Expected: 
User may hold tap on any text within a text field; Cut/Copy/Paste menu appears appropriately.
  
*************************************
Environmental Variables:
----------------------------
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141212040206
Gaia: 1d9ae9cca415ad093beba9521c429350e1f2b14d
Gecko: 5288b15d22de
Gonk: 263b5f41f7733c5577fb101eb4dc8ac5c11cfa8d
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
*************************************  
  
Repro frequency: 5/5
See attached:
video
logcat
(Reporter)

Updated

4 years ago
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Whiteboard: [2.2-Daily-Testing]
(Assignee)

Comment 1

4 years ago
Created attachment 8535740 [details] [review]
GitHub pull request

I originally explicitly did not include user text selection for password fields as I thought it would be undesirable, but meant to confirm with :bhuang. 

On further thought, and trying on another mobile OS, we should allow text selection, but the platform text selection code should be smart enough to not allow Copy from password fields.

And trying this just now, our text selection platform code seems to detect it is a password field and not show a Copy option. (It also does not show a Paste option, but discussion of that is for the platform code, not this ticket)

So, this patch enables the text selection for password fields. I confirmed that Copy was not an option on device, which was my main concern.
Attachment #8535740 - Flags: review?(bugmail)
(Assignee)

Updated

4 years ago
Assignee: nobody → jrburke
Attachment #8535740 - Flags: review?(bugmail) → review+
NI on QA owner for nomination decision.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(pbylenga) → needinfo?(gchang)
(Assignee)

Comment 3

4 years ago
Merged in Gaia master:
https://github.com/mozilla-b2g/gaia/commit/69ae183478367224165f454e4fbff4edcb5a2240

from pull request:
https://github.com/mozilla-b2g/gaia/pull/26747
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Flags: needinfo?(gchang)
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][textselection]
QA Whiteboard: [QAnalyst-Triage+][textselection] → [QAnalyst-Triage+][COM=Text Selection]
You need to log in before you can comment on or make changes to this bug.