Closed Bug 1110932 Opened 8 years ago Closed 8 years ago

GeckoConsole warning Error in parsing value for 'visibility'

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect, P3)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sfoster, Assigned: sfoster)

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Each time card view is opened, we get the following warning logged: 

W/GeckoConsole(  212): [JavaScript Warning: "Error in parsing value for 'visibility'.  Declaration dropped." {file: "app://system.gaiamobile.org/index.html" line: 0 column: 12 source: "visibility: undefined"}]
Comment on attachment 8535780 [details] [review]
[PullReq] sfoster:tm-visibility-warning-bug-1107139 to mozilla-b2g:master

The card view template expects closeButtonVisibility and favoriteButtonVisibility properties, but neither were on the Card prototype. This patch adds default values for those and a little unit test to sanity check instance properties
Attachment #8535780 - Flags: review?(etienne)
Comment on attachment 8535780 [details] [review]
[PullReq] sfoster:tm-visibility-warning-bug-1107139 to mozilla-b2g:master

:+1: :)
Attachment #8535780 - Flags: review?(etienne) → review+
Assignee: nobody → sfoster
Whiteboard: [systemsfe] → [systemsfe] [checkin-needed]
Merged to master: https://github.com/mozilla-b2g/gaia/commit/f59adba1f40553ba26124e4bda24077fbec6c27f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe] [checkin-needed] → [systemsfe]
You need to log in before you can comment on or make changes to this bug.