1110940 - mochitest - support configurable tests.json manifest file name

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: testrun-manifest-file.patch

In Autophone in bug 1079923 I will need to be able to run multiple instances of mochitests from the same tests directory. Mochitest creates a single test manifest tests.json which is created at run time and lists the tests to be run. This is a problem if more than one instance of mochitest/runtests.py or mochitest/runtestsremote.py is run at the same time.

This patch adds --testrun-manifest-file option stored as options.testRunManifestFile with a default value of 'tests.json' to mochitest_options.py and modifies runtests.py to use options.testRunManifestFile instead of the hardcoded 'tests.json'.

It also fixes an existing issue with runtests.py's cleanup where it was possible if a device manager error caused the test to terminate that self.manifest and self.profile might not have yet been set.

It also fixes an indentation problem in runtests.py's getTestManifest.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8535753 [details] [diff] [review]
testrun-manifest-file.patch

Review of attachment 8535753 [details] [diff] [review]:
-----------------------------------------------------------------

nice.  I am not sure I like the many different manifest cli flags.  Once we get rid of the old .json manifest formats (android*.json), and only have .ini formats we can make it just 2 or 3 :)

Comment 2

[Bob Clary [:bc] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb92abb8a0f6

I had tried a try run but could not get android tests to run. I finally gave up
and pushed anyway.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4c0312072512

Comment 3

[(not currently active) Ted Mielczarek]

Times like these make me wish we were just using mozhttpd, and we could just generate the json manifest on the fly in the request.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb92abb8a0f6