1110963 - [Text Selection] Cut/Copy/Paste menu does not dismiss when deleting selected text

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect, P2)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
When a user long presses to select text the "Cut/Copy/Paste" menu will appear. If the user then deletes the selected text this menu will not go away. the menu will not go away until the user selects other text to copy and a new menu appears.

Repro Steps:
1) Update a Flame to 20141212040206
2) Enter contacts
3) Choose to create a new contact
4) Long press the entered text
5) When the menu appears delete the higlighted text
6) Observe menu still being present

Actual:
The Cut/Copy/Paste menu will not disappear after deleting selected text

Expected:
It is expected that the menu dismisses when selected text is deleted

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141212040206
Gaia: 1d9ae9cca415ad093beba9521c429350e1f2b14d
Gecko: 5288b15d22de
Gonk: 263b5f41f7733c5577fb101eb4dc8ac5c11cfa8d
Version: 37.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Repro frequency: 5/5
See attached: video clip, logcat

Comment 1

[Peter Bylenga [:PBylenga]]

Needinfo on QA Lead for blocker nomination, not a regression.

Comment 2

[Gerry Chang [:gchang]]

NI developer for this.

Comment 3

[Peter Chang[:pchang]]

Another sychronization between selectioncarets and text dialog.
When problem happened, I also saw selectionchanged with no_reason.

I/PRLog   (14702): -1225273004[b6a4a080]: SelectionCarets (b2fa1470): NotifySelectionChanged:1126 : aSel (b3dcbd40), Reason=0
I/PRLog   (14702): -1225273004[b6a4a080]: SelectionCarets (b2fa1470): SetVisibility:299 : Set visibility hidden

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

As comment 3, gaia would not receive this selectionchanged event to hide the bubble. Let ni to gecko guy first.

Comment 5

[howie [:howie]]

ni George for verify if the bug still exists.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

The pb still exists.

When launching the bubble and tap on the keyboard, I will receive a selectionstatechanged event with no states which gaia ignore it. However, I think we should put a "blur" inside it to hide the bubble.

And one more pb,
after tapping the keyboard, the bubble is still there, and then I try to tap any place(including input field) of foreground app, the bubble cannot be closed.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive,
could you review this patch?
I also remove scrollend event listener due to bug 1114853 is landed.

Comment 8

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Clear ni since patch has been provided.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
merged to master: https://github.com/mozilla-b2g/gaia/commit/c56dd67573a5f993a364ddc441339ec46e45d22e

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master, marionette test

wait for test.

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8544497 [details] [review]
PR to master, marionette test

Add marionette test for this bug.

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Master: https://github.com/mozilla-b2g/gaia/commit/4b08c61a9bf305a5f3ac563740d32d7ccb57b62f

Comment 14

[howie [:howie]]

Triage: blocker.

Comment 15

[helen（leave from Mozilla）]

Attachment: v2.2.3gp

This bug has been verified as pass on latest build of Flame v2.2 by the STR in Comment 0. 

Results:
The "Cut/Copy/Paste" menu dismisses when selected text is deleted in Contacts app.

Attachment:v2.2.3gp
Rate:0/20

Device: Flame 2.2 (Verified)
Build ID               20150702162501
Gaia Revision          2d6cbec3a4004bb770ecbadbba83f86b95365e56
Gaia Date              2015-07-02 13:40:55
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b465f8d7254f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150702.195016
Firmware Date          Thu Jul  2 19:50:27 EDT 2015
Bootloader             L1TC000118D0