Closed Bug 111102 Opened 22 years ago Closed 21 years ago

Get Msgs button isn't enabled until you focus a pane (disabled or greyed/grayed out on startup)

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.3alpha

People

(Reporter: rushing, Assigned: sspitzer)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

I started Mailnews from 20011120 and it does its newsgroup check, but then it
doesn't give me the Get Msg button. In fact, nothing works until I focus the
folder list. This bug was not present in N6.1

REPRODUCE:
start mail window...you'll see
QA Contact: esther → olgam
*** Bug 111376 has been marked as a duplicate of this bug. ***
i see this on a current cvs, linux. After having read mail and selecting inbox
of popaccount, the get msgs button is disabled. I have to click a mail in the
messagepane to activate it. Confirming, OS: All. Dup reported with Win2000

Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
to repro on Linux:

-Open mailaccount folder (if it isn't open on startup)
-Click on Inbox. Get msgs button is enabled.
-Open a newsgroup folder
-Read a message in the newsgroup
-CLOSE the newsgroup folder, clicking twisty.

Result: Get Msgs button disables

Now click mailaccount's Inbox folder: Get Msgs button is still disabled.

Expected: Button should be enabled.

To re-enable Get Msgs button: click on account-folder or in msg-pane.
Keywords: regression
*** Bug 112711 has been marked as a duplicate of this bug. ***
on a linux CVS build from around midnight(bonsai-time) - i no longer see this bug.
WFM.
*** Bug 108639 has been marked as a duplicate of this bug. ***
I still see this in Linux build 2001-12-12-08, using the steps i gave in bug
108639 (which was duped to this bug):

  1. Have a browser window open.
  2. Open mail. "Get Msgs" button becomes enabled.
  3. Close mail.
  4. Open mail again. "Get Msgs" button unexpectedly remains disabled.


Updating multiple bugs. This is a valid UI issue. Would be nice to have it fixed
if time allows.
reassigning to ssu.
Assignee: sspitzer → ssu
Target Milestone: --- → mozilla1.2
Confirmed using comment 8. (BuildID: 2002 01 08 03).

(click on the selected inbox menu refresh the get msgs button too)
odd. This worked for a while and just regressed for me again - today. (linux)
win32 build 2002012608, win98se

Still reproducible using the steps in comment #4
Wanted to add another test case:
 -login to mail act
 -click on top level Local Folders or newsgroup server
   -notice get msgs button disabled
   -file menu 'get new mesgs' and 'get new mesgs for' disabled
 -click back on a mail folder like the inbox
 result: get msgs button still disabled but file menu 'get new mesgs'
         are enabled
         The only way to enable 'get msgs' button is to select a 
         msg in your mail folder or click on the mail account at top
         level

Why is this targeted for Mozilla 1.2? This is a pretty serious bug! You can't 
click "Get Messages" unless you have figured out that you have to click on the 
folderlist first. How many end users are going to figure that out?
Confirmed using comment #14.

with:
SUNOS 8
build 2002020516

I think is a important bug to fix as soon as possible.
*** Bug 119097 has been marked as a duplicate of this bug. ***
*** Bug 125893 has been marked as a duplicate of this bug. ***
Updating summary to make this a bit easier to find (to avoid dupes).
Summary: get msg button isn't enabled until you focus a pane → Get Msgs button isn't enabled until you focus a pane (disabled or greyed/grayed out on startup)
Attached patch Proposed fix for bug #111102 (obsolete) — Splinter Review
This is a very simple fix for this bug. I'm not sure if it's the right way to
do this, since this is my first patch ever made, but here it goes:

The file \chrome\content\messenger\mailWindowOverlay.xul, line 78, was changed
from

<command id="cmd_getNewMessages" oncommand="goDoCommand('cmd_getNewMessages')"
disabled="true"/>

...to:

<command id="cmd_getNewMessages" oncommand="goDoCommand('cmd_getNewMessages')"
disabled="false"/>

This way, the button is enabled when starting the mail client. It does seem to
work properly here.
Appearantly, my patch didn't do much. :( I've found that if you start Mozilla
from scratch using the -mail switch, the Get Msgs button _is_ enabled on
startup. But if you started the browser first (i.e. mozilla.exe is already
loaded) and _then_ start mail, the button will be disabled.

I thought my patch fixed the bug because the button wasn't disabled, but that
was just because I always started the mail client directly when testing it.
Without knowing anything about the code involved, this seems to me like a race 
condition between the UI loading and mail check starting & completing. For me 
this happens at least when the mail check is VERY fast (as in 0.1 seconds) but 
it would be interesting to see if it's still happening if the mailcheck is very 
slow, so that the UI is done loading when the mail check completes. I'd be 
willing to bet that it only happens with very fast mail checks.. Bug 115257 
seems to be very much related - probably caused by the same thing. However, 
it's no longer happening for me (the status bar text getting stuck). I don't 
know if there was a deliberate fix for it or not, but if there was, I imagine 
this bug about the Get Mesgs button getting stuck could be fixed in the same 
way. Just my €0.02..
I was attempting to fix this last week and saw the same thing David Tenser saw.
 It looks like the focus is taken out of the thread pane and set to (I'm
guessing) the toolbar element after the mailnews window is loaded.  The thread
pane should have the initial focus according to the current code.

Hitting tab twice brings the focus to the quick seach textbox and the Get Msgs
button is enabled at this point.

I'm not sure what's causing this (something in the backend?).  I haven't noticed
this to be a race condition, but I'm not ruling it out either.
Status: NEW → ASSIGNED
*** Bug 129846 has been marked as a duplicate of this bug. ***
I experience this at least three times a day, this bug is very annoying. Is
there any work being done on it? I'd like to see this for 1.0
I agree.. This is pretty serious and should definitely be fixed for 1.0!
*** Bug 135387 has been marked as a duplicate of this bug. ***
As the previous replies say, this IS very annoying (I am now seeing it on 
OpenVMS). Can we get this nominated for 1.0?
I can't nominate, so could the owner add the mozilla1.0 keyword?
I don't think its a race, I have 5 accounts that get checked at startup, some
take a long time to respond, yet the button is always disabled when the mail
window is opened from an existing browser session. The bug does NOT occur when a
mail session is launched using a ...mozilla.exe -mail shortcut. It only happens
when the mail window is launched from an existing session.

Why is the button ever disabled? Once you click the message window, nothing you
do will disable it again. So, does it ever really need to be disabled? 

This is an important bug, it effects elementary usability. A novice user will
not understand why they have to click here, then there to get mail. They will
say, "Outlook doesn't make me do that." It says this is sceduled to be fixed for
1.2 Why wait when there is already a proposed patch?
Comment on attachment 69882 [details] [diff] [review]
Proposed fix for bug #111102

> It says this is sceduled to be fixed for 1.2
> Why wait when there is already a proposed patch?

Because the patch doesn't work (see comment 21).
Attachment #69882 - Attachment is obsolete: true
Oh, and this is incorrect:

> Why is the button ever disabled? Once you click the message window, nothing you
> do will disable it again. So, does it ever really need to be disabled?

Selecting Local Folders will disable the button.
Selecting Local Folders disabling the button is bug 113874. (maybe it could get
fixed together with this one? It seems a comparable issue but it's been around
longer)
Keywords: mozilla1.0
*** Bug 132803 has been marked as a duplicate of this bug. ***
*** Bug 139681 has been marked as a duplicate of this bug. ***
I've noticed that the first time you open the mail window, the Get Msg button
*IS* enabled like it should be. It is only on subsequent window openings that it
is disabled. Hopefully that provides some clues.
*** Bug 143442 has been marked as a duplicate of this bug. ***
*** Bug 140760 has been marked as a duplicate of this bug. ***
*** Bug 147860 has been marked as a duplicate of this bug. ***
I'm not sure if this is an escallation or not but if you open Mail & News for
the first time after launching Mozilla, the button will be enabled. On
subsequent launches of Mail & News, it will be disabled and clicking on the
thread pane will enable it. However, clicking on "Compose" and then closing the
composer window will make it so that you can't get the "Get Msgs" button enabled
no matter what you do (until you restart Mozilla).
*** Bug 159149 has been marked as a duplicate of this bug. ***
Blocks: 164421
Blocks: 165832
added myself to CC
adding self to cc list.
There was no activity for a long time. We already missed the target milestone.
Any hope to get this fixed for 1.2b?

pi
I have this problem, as described in comment 36 with 2002091014 (1.2 beta) and
Win98 SE.
It is interesting to note (and maybe it helps fix this) that the "Get Messages"
menu item is activated at times even the Button is greyed out.  Details:

1.  Select "local folders" to grey out the button and menu item.  
2.  Select "inbox" for a mail account.

At this point the Get Messages button is still grey, but the menu item IS available.

I tried tracking this down, but not knowing the code well enough I was only able
to notice (I think) that menu items and buttons are activated in different
sections of code.  (I forget exactly which files, but I got confused when trying
to figure out the behavior when focus is changed between elements of the same
frame.)

My apologies if this should have been under Bug 113874, they seem to be very
similar.
*** Bug 172635 has been marked as a duplicate of this bug. ***
Umm.. isn't it a bit late for 1.2alpha?
*** Bug 174032 has been marked as a duplicate of this bug. ***
*** Bug 123222 has been marked as a duplicate of this bug. ***
*** Bug 176470 has been marked as a duplicate of this bug. ***
*** Bug 178025 has been marked as a duplicate of this bug. ***
taking.

today is "fix get msg button problems" day.
Assignee: ssu → sspitzer
Status: ASSIGNED → NEW
Target Milestone: mozilla1.2alpha → mozilla1.3alpha
accepting
Status: NEW → ASSIGNED
That day of the year, huh? Then feel free to fix bug 125885 too. ;)
Bug 172939 mioght be a DUP of this
*** Bug 140741 has been marked as a duplicate of this bug. ***
*** Bug 172939 has been marked as a duplicate of this bug. ***
Have you thought about fixing that bug from a different side? Since after
selecting any mail folder gets the icons enabled, why not make the first folder
selected by default (and not just highlighted as it is now) - this would be
preferable for great most of the users and would provide a quick and easy fix.
I've fixed this.  see my patch in bug #89404

> why not make the first folder selected by default (and not just highlighted as 
> it is now) - this would be
> preferable for great most of the users and would provide a quick and easy fix.

that's what the "check for new messages at startup" checkbox will do, as a side
effect
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
*** Bug 179929 has been marked as a duplicate of this bug. ***
Ok, seems to work now (Build from 13.November 2002)
Anyone V.?
QA Contact: olgam → stephend
I'm happy to say it seems to be working fine now... :)
Works for me, too. Yay!
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021122
Verified FIXED with:

Mac OS X 10.2.2 - 2002-11-22-12
Linux RedHat 8.0 - 2002-11-22-08
Windows 2000 - 2002-11-22-08

I couldn't find an instance where GetMsgs is disabled at all.

Note: For the actual functionality of the button, see Esther's verification at:
http://bugzilla.mozilla.org/show_bug.cgi?id=89404#c23 in bug 89404.
Status: RESOLVED → VERIFIED
Hardware: PC → All
NOT fixed on the 1.2 branch.

Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.2) Gecko/20021121
Hmmm... just installed 1.2 (win2k) and pretty quickly saw the problem again.

Both after browsing "Local Folders" and usenet ones.

sTu.
This bug was only fixed and verified on the trunk (not the 1.2 branch).

If you want to see this working, you'll have to download a current trunk nightly
build from ftp://ftp.mozilla.org/pub/mozilla/nightly/latest-trunk
*** Bug 199236 has been marked as a duplicate of this bug. ***
Sorry.  But in my defense now, I tried to search for this bug before I submitted
it, but your website is broken or something.  Everytime I tried to search for
"get messages buttion" or something of that sort it would tell me I entered an
invalid bug id.
Product: Browser → Seamonkey
No longer blocks: 164421
Blocks: 158464
You need to log in before you can comment on or make changes to this bug.