Closed Bug 1111063 Opened 5 years ago Closed 5 years ago

Support XPCOMBinaryComponent with msvcrt=static

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: rkent, Assigned: rkent)

Details

Attachments

(1 file)

In building binary extensions using the Mozilla build system, it is advantageous to link with xpcomglue_staticruntime to prevent dependencies on versions of the Windows runtime installed on a system. Recent build system changes have made that inaccessible.
Attached patch 1111063.patchSplinter Review
AS we discussed in IRC
Attachment #8535927 - Flags: review?(mh+mozilla)
Attachment #8535927 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
can we get a try link here, thanks!
Flags: needinfo?(kent)
Keywords: checkin-needed
Try link:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=91b76b868bdc

Only builds were done, not tests, as this is a change to the build system in support of extensions, that has no impact on shipped code.
Flags: needinfo?(kent)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9a464275ec43
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.