"Thanks for signing up!" newsletter footer persists when navigating to another page

RESOLVED INCOMPLETE

Status

Marketplace
Consumer Pages
P3
normal
RESOLVED INCOMPLETE
3 years ago
3 years ago

People

(Reporter: cvan, Assigned: u489517)

Tracking

2014-12-16
x86
Mac OS X
Points:
---
Dependency tree / graph

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8535905 [details]
screenshot of "Thanks for signing up!" in newsletter footer

1. Load https://marketplace-dev.allizom.org/ on desktop.
2. Scroll to the bottom and sign up for the newsletter.
3. Notice the "Thanks for signing up!" message appears.
4. Navigate to like another page (e.g., Popular page or an app detail page).
5. Notice the "Thanks for signing up!" message still appears.
6. Refresh the page in your browser.
7. Notice the original newsletter form is shown.
Ah, yeah, since it's in the footer... We could hide the newsletter part of the footer when the user navigates away, if it was successful.
+1 to what mat said, and preserve that for the session.
Assignee: nobody → mstriemer
Priority: -- → P3

Updated

3 years ago
Blocks: 1110561
https://github.com/mozilla/fireplace/pull/857
Status: NEW → ASSIGNED
https://github.com/mozilla/fireplace/commit/cd1e8b423099f9564ac3561a84bd066520d4bac3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-12-16

Comment 5

3 years ago
Verified as fixed in https://marketplace.allizom.org/ on FF 37 (Win 7).
Postfix screencast http://screencast.com/t/LBsNfBrpmoCm
Closing bug.
Status: RESOLVED → VERIFIED

Updated

3 years ago
Blocks: 1113354
This unfortunately made it to production earlier than anticipated. We're going to hold off on making a change like this until we get a spec from UX.

Reverted in https://github.com/mozilla/fireplace/commit/a03f7c4687299acd718810c8e2faeb939a763a19
Status: VERIFIED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: FIXED → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.