Treeherder masks visited links since they are the same colour

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Details

Attachments

(1 attachment)

49 bytes, text/x-github-pull-request
camd
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
In TBPL I very frequently relied on being able to differentiate visited and non-visited links using their coloring.  TreeHerder forces both types of links to be the same color, hence breaking this workflow.
(Assignee)

Comment 1

4 years ago
Created attachment 8543440 [details] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #8543440 - Flags: review?(emorley)

Comment 2

4 years ago
Comment on attachment 8543440 [details] [review]
Patch (v1)

Thank you for looking at this :-)

The file changed by this PR is currently untouched from upstream afaik, so I'm pretty sure we don't want to add this here. Though I'll defer to :camd, since he's handled the bootstrap upgrades.
Attachment #8543440 - Flags: review?(emorley) → review?(cdawson)

Updated

4 years ago
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Summary: TreeHerder masks visited links → Treeherder masks visited links since they are the same colour
Comment on attachment 8543440 [details] [review]
Patch (v1)

@ehsan - thanks for tackling this. Though I agree with Ed. I wouldn't want to modify bootstrap.css directly. Can you add this as an override in treeherder.css instead?? That way, when we upgrade to the latest bootstrap at some point, we don't have to know where to modify their .css file.

Thanks!
Attachment #8543440 - Flags: review?(cdawson) → review-
(Assignee)

Comment 4

4 years ago
Comment on attachment 8543440 [details] [review]
Patch (v1)

Updated the PR based on comments.
Attachment #8543440 - Flags: review- → review?(cdawson)

Comment 5

4 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/68372ed8c23b6cc1eebeaacb10e75177f4bf4b66
Bug 1111157 - Give visited links their own color; r=edmorley

https://github.com/mozilla/treeherder-ui/commit/006002b74fa720b4d8cf0dcea0ff20cdffa67470
Merge pull request #324 from ehsan/visited

Bug 1111157 - Give visited links their own color

Updated

4 years ago
Attachment #8543440 - Flags: review?(cdawson) → review+

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

4 years ago
Thanks!  How do we get this deployed?

Comment 7

4 years ago
We're doing roughly weekly deploys at the moment (we need to be more careful than we will in the future, since the deploying is slightly fragile; bug 1079270) - so no need to do anything for now :-)
Was this ever deployed? On TH I see the same style for visited and non-visited bug links. I also find it useful to be able to distinguish between the two.

Comment 9

4 years ago
This was deployed, but bug 1125126 updated the colour and made the rule invalid in the process - good spot, thank you :-)
Depends on: 1125126

Comment 10

4 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d44cdbb7956424f4814fd61696976258d8e423c5
Bug 1111157 - Give visited links their own color; r=edmorley

https://github.com/mozilla/treeherder/commit/43a11f032a0cdb2cc2d7dd575e2d7d83e1d83ed3
Merge pull request #324 from ehsan/visited

Bug 1111157 - Give visited links their own color
You need to log in before you can comment on or make changes to this bug.