1111157 - Treeherder masks visited links since they are the same colour

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[(no longer active)]

In TBPL I very frequently relied on being able to differentiate visited and non-visited links using their coloring.  TreeHerder forces both types of links to be the same color, hence breaking this workflow.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8543440 [details] [review]
Patch (v1)

Thank you for looking at this :-)

The file changed by this PR is currently untouched from upstream afaik, so I'm pretty sure we don't want to add this here. Though I'll defer to :camd, since he's handled the bootstrap upgrades.

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8543440 [details] [review]
Patch (v1)

@ehsan - thanks for tackling this. Though I agree with Ed. I wouldn't want to modify bootstrap.css directly. Can you add this as an override in treeherder.css instead?? That way, when we upgrade to the latest bootstrap at some point, we don't have to know where to modify their .css file.

Thanks!

Comment 4

[(no longer active)]

Comment on attachment 8543440 [details] [review]
Patch (v1)

Updated the PR based on comments.

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/68372ed8c23b6cc1eebeaacb10e75177f4bf4b66
Bug 1111157 - Give visited links their own color; r=edmorley

https://github.com/mozilla/treeherder-ui/commit/006002b74fa720b4d8cf0dcea0ff20cdffa67470
Merge pull request #324 from ehsan/visited

Bug 1111157 - Give visited links their own color

Comment 6

[(no longer active)]

Thanks!  How do we get this deployed?

Comment 7

[Ed Morley [:emorley]]

We're doing roughly weekly deploys at the moment (we need to be more careful than we will in the future, since the deploying is slightly fragile; bug 1079270) - so no need to do anything for now :-)

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Was this ever deployed? On TH I see the same style for visited and non-visited bug links. I also find it useful to be able to distinguish between the two.

Comment 9

[Ed Morley [:emorley]]

This was deployed, but bug 1125126 updated the colour and made the rule invalid in the process - good spot, thank you :-)

Comment 10

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d44cdbb7956424f4814fd61696976258d8e423c5
Bug 1111157 - Give visited links their own color; r=edmorley

https://github.com/mozilla/treeherder/commit/43a11f032a0cdb2cc2d7dd575e2d7d83e1d83ed3
Merge pull request #324 from ehsan/visited

Bug 1111157 - Give visited links their own color