Closed Bug 1111218 Opened 8 years ago Closed 8 years ago

Fold congruent type barriers

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
The testcase in bug 1111000 uses a lot of variables in an outer scope, so we have GETALIASEDVAR ops with type barriers. We're able to fold the loads but not the type barriers, so we end up with many barriers testing the same types and this also inhibits other GVN optimizations.

This patch allows us to fold them and is at least a 10% win on that testcase.
Attachment #8536029 - Flags: review?(bhackett1024)
Attachment #8536029 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/c680f3928f86
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.