Closed Bug 1111244 Opened 6 years ago Closed 6 years ago
Remove some code specific to old unsupported MSVC versions from js/src
No description provided.
Attachment #8536063 - Flags: review?(jwalden+bmo) → review+
Backed out all three commits that refer to this bug number for Windows build bustage: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4654885&repo=mozilla-inbound remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/01744fb7dc11 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/4f239165dbb2 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/b836016d82b5 Though it looks like one of those might have used the wrong bug number. ("Move TestExpirationTracker.cpp to gtest and enable it; r=froydnj")
Jeff, is there a way to make check_spidermonkey_style.py shut up about this?! ;-) Clearly it doesn't know what it's talking about at all.
Flags: needinfo?(ehsan.akhgari) → needinfo?(jwalden+bmo)
(In reply to Wes Kocher (:KWierso) from comment #2) > Backed out all three commits that refer to this bug number for Windows build > bustage: > https://treeherder.mozilla.org/ui/logviewer. > html#?job_id=4654885&repo=mozilla-inbound > > > remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/01744fb7dc11 > remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/4f239165dbb2 > remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/b836016d82b5 > > > Though it looks like one of those might have used the wrong bug number. > ("Move TestExpirationTracker.cpp to gtest and enable it; r=froydnj") Nope, it's 1111244 vs 1111224. :-)
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #4) > Nope, it's 1111244 vs 1111224. :-) Oops. Feel free to reland that one, then... :)
This was working before because check_spidermonkey_style.py doesn't try to reorder past #ifdefs. But don't we usually just #include "jswin.h" instead? Maybe prmjtime.cpp is special though.
By 'reorder' I meant 'check the ordering'.
prmjtime.cpp is indeed "special" and should Die In A Fire. I just tweaked the include order so you should be able to do what you were going to do without troubles. (The two win*.h are Special Snowflakes that are permitted to be out of order; the rest has to be ordered, tho.) https://hg.mozilla.org/integration/mozilla-inbound/rev/11cd67870971 (In the extreme outside change of Windows-only compile failures due to an ordering requirement among these three includes, this is the patch from the push-range to back out. But I rather doubt it, for these non-<win*.h> headers.)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.