Marionette._handle_error is missing error message on malformed packet

RESOLVED FIXED in mozilla37

Status

Testing
Marionette
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

({ateam-marionette-client})

unspecified
mozilla37
ateam-marionette-client
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
When an unexpected or malformed packet is received, Marionette._handle_error prints the packet but does not offer any explanation what the problem is.  This is frustrating from a debugging point of view.
(Assignee)

Updated

3 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Keywords: ateam-marionette-client
(Assignee)

Comment 1

3 years ago
Created attachment 8536077 [details]
MozReview Request: bz://1111246/ato
Attachment #8536077 - Flags: review?(dburns)
(Assignee)

Comment 2

3 years ago
/r/1447 - Bug 1111246 - Add error message in Marionette client on malformed packet; r=dburns

Pull down this commit:

hg pull review -r b1d14cc89776947206d5e3daa6f558617241f9cf
(Assignee)

Comment 3

3 years ago
/r/1447 - Bug 1111246 - Add error message in Marionette client on malformed packet; r=dburns
/r/1449 - Add missing test

Pull down these commits:

hg pull review -r b7fed0248bf420bf77b739b4ad6dd0a791a7e315
Attachment #8536077 - Flags: review?(dburns) → review+
https://reviewboard.mozilla.org/r/1445/#review903

Ship It!
(Assignee)

Comment 5

3 years ago
/r/1447 - Bug 1111246 - Add error message in Marionette client on malformed packet; r=dburns

Pull down this commit:

hg pull review -r 550ef223852fc0d163f90f535c73ae1aeebc20b1
Attachment #8536077 - Flags: review+ → review?(dburns)
(Assignee)

Comment 6

3 years ago
try on unfolded commits: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d1a9459287cc

Revision history on mozreview is squashed.
Keywords: checkin-needed
(Assignee)

Comment 7

3 years ago
Comment on attachment 8536077 [details]
MozReview Request: bz://1111246/ato

Carrying on r+, I clearly did something wrong when rebasing.
Attachment #8536077 - Flags: review?(dburns) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/97565b594f02
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/97565b594f02
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
(Assignee)

Comment 10

2 years ago
Comment on attachment 8536077 [details]
MozReview Request: bz://1111246/ato
Attachment #8536077 - Attachment is obsolete: true
Attachment #8618918 - Flags: review+
Attachment #8618919 - Flags: review+
(Assignee)

Comment 11

2 years ago
Created attachment 8618918 [details]
MozReview Request: Add missing test
(Assignee)

Comment 12

2 years ago
Created attachment 8618919 [details]
MozReview Request: Bug 1111246 - Add error message in Marionette client on malformed packet; r=dburns
You need to log in before you can comment on or make changes to this bug.