Closed Bug 1111246 Opened 7 years ago Closed 7 years ago

Marionette._handle_error is missing error message on malformed packet

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: ato, Assigned: ato)

Details

(Keywords: pi-marionette-client)

Attachments

(2 files, 1 obsolete file)

When an unexpected or malformed packet is received, Marionette._handle_error prints the packet but does not offer any explanation what the problem is.  This is frustrating from a debugging point of view.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attached file MozReview Request: bz://1111246/ato (obsolete) —
Attachment #8536077 - Flags: review?(dburns)
/r/1447 - Bug 1111246 - Add error message in Marionette client on malformed packet; r=dburns

Pull down this commit:

hg pull review -r b1d14cc89776947206d5e3daa6f558617241f9cf
/r/1447 - Bug 1111246 - Add error message in Marionette client on malformed packet; r=dburns
/r/1449 - Add missing test

Pull down these commits:

hg pull review -r b7fed0248bf420bf77b739b4ad6dd0a791a7e315
Attachment #8536077 - Flags: review?(dburns) → review+
/r/1447 - Bug 1111246 - Add error message in Marionette client on malformed packet; r=dburns

Pull down this commit:

hg pull review -r 550ef223852fc0d163f90f535c73ae1aeebc20b1
Attachment #8536077 - Flags: review+ → review?(dburns)
try on unfolded commits: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d1a9459287cc

Revision history on mozreview is squashed.
Keywords: checkin-needed
Comment on attachment 8536077 [details]
MozReview Request: bz://1111246/ato

Carrying on r+, I clearly did something wrong when rebasing.
Attachment #8536077 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/97565b594f02
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Attachment #8536077 - Attachment is obsolete: true
Attachment #8618918 - Flags: review+
Attachment #8618919 - Flags: review+
You need to log in before you can comment on or make changes to this bug.