Incorrect reference to nsITimer.TYPE_ONE_SHOT in marionette-server.js

RESOLVED FIXED in mozilla37

Status

Testing
Marionette
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

({ateam-marionette-server})

unspecified
mozilla37
ateam-marionette-server
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
marionette-server.js has four incorrect references to nsITimer.TYPE_ONE_SHOT that trigger ReferenceError's at runtime.

The affected code only works by chance that the constant TYPE_ONE_SHOT's value is 0.

Affected lines as of 219503:f14dcd1c8c0b:

% g ONESHOT
./marionette-server.js:892:       }, inactivityTimeout, Ci.nsITimer.TYPE_ONESHOT);
./marionette-server.js:1055:      }, inactivityTimeout, Ci.nsITimer.TYPE_ONESHOT);
./marionette-server.js:1063:       }, inactivityTimeout, Ci.nsITimer.TYPE_ONESHOT);
./marionette-server.js:1131:        }, that.timeout, Ci.nsITimer.TYPE_ONESHOT);
(Assignee)

Updated

3 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Keywords: ateam-marionette-server
(Assignee)

Comment 1

3 years ago
Created attachment 8536079 [details]
MozReview Request: bz://1111260/ato
Attachment #8536079 - Flags: review?(dburns)
(Assignee)

Comment 2

3 years ago
/r/1453 - Bug 1111260 - Fix references to nsITimer.TYPE_ONE_SHOT; r=dburns

Pull down this commit:

hg pull review -r f6174b2e3740a0cb17fae802aad22ccbc7234638
Attachment #8536079 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/13d74279980e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
(Assignee)

Comment 7

3 years ago
Comment on attachment 8536079 [details]
MozReview Request: bz://1111260/ato
Attachment #8536079 - Attachment is obsolete: true
Attachment #8618920 - Flags: review+
(Assignee)

Comment 8

3 years ago
Created attachment 8618920 [details]
MozReview Request: Bug 1111260 - Fix references to nsITimer.TYPE_ONE_SHOT; r=dburns
You need to log in before you can comment on or make changes to this bug.