Closed Bug 1111275 Opened 7 years ago Closed 7 years ago

Replace gBrowser.mCurrentBrowser with gBrowser.selectedBrowser

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 37

People

(Reporter: dao, Assigned: tejdeepg, Mentored)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

Path for Bug 1111275
3.20 KB, patch
dao
: review+
Details | Diff | Splinter Review 
mCurrentBrowser is a private property of the tabbrowser binding. It shouldn't be used from the outside. selectedBrowser should be used instead.

Affected files:

/browser/base/content/browser.js
/browser/base/content/urlbarBindings.xml
/browser/components/search/content/search.xml
Comment on attachment 8536320 [details] [diff] [review]
Path for Bug 1111275

Thanks!
Attachment #8536320 - Flags: review+
@dao , I am pretty new here, will the patch be landed by you guys or is there anything I should do ?
You would usually add the "checkin-needed" keyword to the bug for your patch to get landed. Comment 3 means that I already landed this patch on the "fx-team" integration repository. From there it should be merged to mozilla-central after a day or two, at which point this bug will be resolved.
ok, thanks
https://hg.mozilla.org/mozilla-central/rev/cf9718aa24bc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
You need to log in before you can comment on or make changes to this bug.