1111288 - a potential memory leak - caused by forgetting to free after realloc failure

Status: UNCONFIRMED

(Core :: JavaScript Engine, defect)

Description

[yxcynthia]

Attachment: memory leak target

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36

Steps to reproduce:

run cppcheck on mozilla-central/js/src/editline/editline.c


Actual results:

on line 153: 'screen' nulled but not freed upon failure


Expected results:

the 'screen' should be freed if the 'RENEW' fails, but not handled in the code

Comment 1

[(no longer active)]

I think we can just use moz_xrealloc in RENEW to make this realloc infallible.

Comment 2

[Nicholas Nethercote [inactive]]

> I think we can just use moz_xrealloc in RENEW to make this realloc
> infallible.

Not within Spidermonkey, unfortunately. But we can make RENEW call MOZ_CRASH() on failure.

I'm pretty sure this code is only used in the JS shell, not the browser, which reduces the priority a little.