Closed Bug 1111319 Opened 5 years ago Closed 5 years ago
Mac: H264 video playback excessively juddery sometimes
On mac, I've noticed that video playback is often juddery. Far more than it ought to be. This is particularly obvious in panning scene like in this video: http://people.mozilla.org/~jyavenard/mediatest/avc3.mp4 Using FFmpeg decoder is super smooth; the the Apple's h264 decoder isn't anywhere as smooth.
frames in that video are returned out of order.
Assignee: nobody → jyavenard
Summary: H264 video playback excessively juddery sometimes → Mac: H264 video playback excessively juddery sometimes
Debugging patch, this will abort whenever we return a frame out of order
Re-order frame according to defined sliding decoding window.
Attachment #8540600 - Flags: review?(giles)
Comment on attachment 8540600 [details] [diff] [review] Reorder video frames with respect to decoding sliding window Review of attachment 8540600 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comment addressed. ::: dom/media/fmp4/apple/AppleVDADecoder.cpp @@ +295,1 @@ > mCallback->Output(readyData); Fix indent. This is a single line without the nsRefPtr in DrainReorderedFrames() which I think would also be fine here now that we don't have any other code touching readyData.
Attachment #8540600 - Flags: review?(giles) → review+
Rebase for new patch, and handle seeks. No crashes so far with this current version of the patch
Attachment #8540539 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8540600 [details] [diff] [review] Reorder video frames with respect to decoding sliding window Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing; sites more likely to serve flash video. [Describe test coverage new/current, TBPL]: Landed on m-c. [Risks and why]: We change the way we reorder frames for display, so playback will be different for some files. Seems to work better in practice than what we had before. [String/UUID change made/needed]: None.
Attachment #8540600 - Flags: approval-mozilla-aurora?
Attachment #8540600 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Backed out so bug 1111328 would backout cleanly. https://hg.mozilla.org/releases/mozilla-aurora/rev/7c15e189d452
You need to log in before you can comment on or make changes to this bug.