1111319 - Mac: H264 video playback excessively juddery sometimes

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

On mac, I've noticed that video playback is often juddery. Far more than it ought to be.

This is particularly obvious in panning scene like in this video:
http://people.mozilla.org/~jyavenard/mediatest/avc3.mp4

Using FFmpeg decoder is super smooth; the the Apple's h264 decoder isn't anywhere as smooth.

Comment 1

[Jean-Yves Avenard [:jya]]

frames in that video are returned out of order.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: assert if we're getting a frame out of order

Debugging patch, this will abort whenever we return a frame out of order

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Reorder video frames with respect to decoding sliding window

Re-order frame according to defined sliding decoding window.

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8540600 [details] [diff] [review]
Reorder video frames with respect to decoding sliding window

Review of attachment 8540600 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: dom/media/fmp4/apple/AppleVDADecoder.cpp
@@ +295,1 @@
>        mCallback->Output(readyData);

Fix indent.

This is a single line without the nsRefPtr in DrainReorderedFrames() which I think would also be fine here now that we don't have any other code touching readyData.

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: assert if we're getting a frame out of order

Rebase for new patch, and handle seeks. No crashes so far with this current version of the patch

Comment 6

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a596989277c5

Comment 7

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a7e45fb4b943

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a7e45fb4b943

Comment 9

[Ralph Giles (:rillian)]

Comment on attachment 8540600 [details] [diff] [review]
Reorder video frames with respect to decoding sliding window

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing; sites more likely to serve flash video.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: We change the way we reorder frames for display, so playback will be different for some files. Seems to work better in practice than what we had before.
[String/UUID change made/needed]: None.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f92070ac5632

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Backed out so bug 1111328 would backout cleanly.
https://hg.mozilla.org/releases/mozilla-aurora/rev/7c15e189d452

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/451ed5c44843