Closed Bug 1111398 Opened 6 years ago Closed 6 years ago

Rename ValidDNSIDMatchType to IDRole

Categories

(Core :: Security: PSM, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file)

In pkixnames.cpp, we use variables named XXXNameType for two different kinds of name categorizations: GeneralNameType and ValidDNSIDMatchType. That is confusing. Also, ValidDNSIDMatchType is a terrible name, especially since we now use it in more places than in IsValidDNSID. I rename the type to IDRole and rename some of the variables of that type here.
Attachment #8536235 - Flags: review?(dkeeler)
https://hg.mozilla.org/mozilla-central/rev/5e53f5ad4e5d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.