Closed Bug 1111471 Opened 7 years ago Closed 7 years ago

[Stingray][Home] Newly pinned card should be located right after its parent card

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwi2, Assigned: rexboy)

References

Details

(Whiteboard: [ft:conndevices][ETA:1/16])

Attachments

(1 file)

Currently newly pinned card is located at the end of card list in Home app, but it should be located right after its parent card. (For example, right after Apps deck)
And the focus should be on the card just recently pinned.
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Whiteboard: [ft:conndevices] → [ft:conndevices][ETA:1/23]
Assignee: tzhuang → rexboy
Whiteboard: [ft:conndevices][ETA:1/23] → [ft:conndevices][ETA:1/16]
Attached file Patch
Done. There's a column called 'group' added in DB to accomplish the feature.
Tzu-lin would you help review this patch?
Attachment #8549518 - Flags: review?(tzhuang)
Comment on attachment 8549518 [details] [review]
Patch

r+ with just one nit. Thanks
Attachment #8549518 - Flags: review?(tzhuang) → review+
Hi Rex, can we land and close this?
Flags: needinfo?(rexboy)
I'm waiting for test server. I'll wait for it and land as soon as possible.
Flags: needinfo?(rexboy)
https://github.com/mozilla-b2g/gaia/commit/579e01ad4d6e4177a8f636305ac877835d99f134
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.