Closed
Bug 1111472
Opened 9 years ago
Closed 9 years ago
[Stingray][Home] Same card should not be pinned twice in Home app
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: dwi2)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
Each card should have at most one instance on card list in Home app.
Assignee | ||
Updated•9 years ago
|
Blocks: CardUI-Followup
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Component: Gaia → Gaia::TV::Home
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8568459 [details] [review] [gaia] dwi2:bug1111472 > mozilla-b2g:master Hi Rex, Please help to review the patch. This patch prevents same card from being inserted twice.
Attachment #8568459 -
Flags: review?(rexboy)
Comment 3•9 years ago
|
||
Comment on attachment 8568459 [details] [review] [gaia] dwi2:bug1111472 > mozilla-b2g:master r=me. Thanks for fixing this. Notice that card_manager shouldn't run into this case under usual use since apps who want to add a card should check if the card is already exist (and show unpin if already existed) first.
Attachment #8568459 -
Flags: review?(rexboy) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/c419aaa0ee8bf1487bcc65c1d0beb5c63a2b3df1
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•