1111494 - [gaia-components] Allow the gaia-confirm title to be multiple lines

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Components, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

It is common that the title in gaia-confirm has to be multi-line and in most of the cases it is difficult to shorten the titles.

However, this directly contradicts the fix in bug 1061441. Although apps could override the style for their owe use, but it would make more sense having the default style fit the most common use case.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Cristian, is it possible that the fix of bug 1061441 be done in the collection app?

Comment 2

[Cristian Rodriguez (:crdlc)]

I am not working actively in Gaia nowadays, forwarding to Kevin

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1111494_gaia_confirm_title_height to mozilla-b2g:master

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8536825 [details] [review]
[PullReq] KevinGrandon:bug_1111494_gaia_confirm_title_height to mozilla-b2g:master

Arthur - could you review this for me?

I think it's important to constrain the header to *some* length, and three lines seems reasonable to me. Let me know what you think, and if this is enough room let's go with this. Thanks!

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8536825 [details] [review]
[PullReq] KevinGrandon:bug_1111494_gaia_confirm_title_height to mozilla-b2g:master

Limiting the max length makes sense, r=me. Thanks.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: b4ce4ff1041476e4fd8660c2363273b4c2e0e82a