Closed Bug 1111560 Opened 9 years ago Closed 9 years ago

Upgrade Loop's use of sinon to version 1.12.2

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal
Points:
1

Tracking

(firefox35 fixed, firefox36 fixed, firefox37 fixed)

RESOLVED FIXED
mozilla37
Iteration:
37.2
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

For bug 1097862, I need to use an sync ajax request, however due to an old issue with jQuery and sinon working together, we need to use a more up to date version of sinon - hence we should just upgrade it.

See
http://stackoverflow.com/questions/24961056/sinon-js-1-10-jquery-2-1-and-synchronous-request
https://github.com/cjohansen/Sinon.JS/pull/564
Tests pass with sinon upgraded, so no changes necessary.
Attachment #8536527 - Flags: review?(nperriault)
Comment on attachment 8536527 [details] [diff] [review]
Upgrade Loop's use of sinon to version 1.12.2.

Review of attachment 8536527 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks!
Attachment #8536527 - Flags: review?(nperriault) → review+
https://hg.mozilla.org/integration/fx-team/rev/df4c50342efb
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/df4c50342efb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8536527 [details] [diff] [review]
Upgrade Loop's use of sinon to version 1.12.2.

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: Blocks fixing problems in the tests for the UI

[Describe test coverage new/current, TBPL]: On m-c.  No changes needed to use the import; used in Loop tests

[Risks and why]: basically no risk given tests pass with it.  NPOTB

[String/UUID change made/needed]: none
Attachment #8536527 - Flags: approval-mozilla-beta?
Attachment #8536527 - Flags: approval-mozilla-aurora?
Attachment #8536527 - Flags: approval-mozilla-beta?
Attachment #8536527 - Flags: approval-mozilla-beta+
Attachment #8536527 - Flags: approval-mozilla-aurora?
Attachment #8536527 - Flags: approval-mozilla-aurora+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.