Closed
Bug 1111565
Opened 9 years ago
Closed 9 years ago
155% Android 4 tcheck2 regression on fx-team (v.37) Dec 9 from push e2f022366721
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jmaher, Unassigned)
References
Details
(Keywords: perf, regression, Whiteboard: [talos_regression])
graph server shows us the regression we care about: http://graphs.mozilla.org/graph.html#tests=%5B%5B201,64,29%5D%5D&sel=1418078849000,1418251649000&displayrange=7&datatype=running I did some retriggers to verify this is a valid regression: https://tbpl.mozilla.org/?tree=Fx-Team&fromchange=13c5e6f5657d&tochange=e15dfc5e7381&jobname=fx-team%20talos%20remote-trobocheck2&showAll=1 and this is the changeset where we go from <9.0 to >15.0: https://hg.mozilla.org/integration/fx-team/rev/e2f022366721
Reporter | ||
Comment 1•9 years ago
|
||
Hey Lucas, I see the bug this patch is related to was to fix a talos regression, but it introduced a different one? I didn't see any improvements in the android talos numbers related to this. Could you weigh in if this is expected, if not should we investigate or accept it?
Flags: needinfo?(lucasr.at.mozilla)
Comment 2•9 years ago
|
||
Based on the Chart and the Regression Range, I'd say the cause is: http://hg.mozilla.org/integration/fx-team/rev/4f72c81d5441 (bug 1097318) Which makes sense, since we know it affected Talos before and was backed out. After some investigation, we decided that the 4dp change in height did not visibly change performance and we could not find a reason why a 4dp change in toolbar height suddenly caused the Talos test to regress. In the end, we decided to allow the baseline to change.
Flags: needinfo?(lucasr.at.mozilla)
Reporter | ||
Comment 3•9 years ago
|
||
thanks mfinkle. I will mark this as wontfix and we can ignore the test as it goes through the branches.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•