1111640 - Don't de-serialize json string of uploaded_files in blob_upload.py

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Andrew Halberstadt [:ahal]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1107571#c33 and down.

I thought set_buildbot_property would let me set a dict, but turns out it needs to be serialized. This means we shouldn't de-serialize the object in blob_upload.py. Doing so forces buildbot to re-serialize the object in a non-json format which makes it more difficult for consumers to deal with.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: bz://1111640/ahal

Comment 2

[Andrew Halberstadt [:ahal]]

/r/1465 - Bug 1111640 - Don't de-serialize uploaded_files in blob_upload.py, r=armenzg

Pull down this commit:

hg pull review -r 99b22a719061e18eb330894720ebfaf3b64c18bf

Comment 3

[Armen [:armenzg]]

https://reviewboard.mozilla.org/r/1463/#review881

This will do the trick. Thanks ahal.

Comment 4

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/build/mozharness/rev/99b22a719061

Comment 5

[Armen [:armenzg]]

mozharness change merged to production.

Comment 7

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1111640 - Don't de-serialize uploaded_files in blob_upload.py, r=armenzg