1111670 - Stop shipping unused defaults/profile files

Status: RESOLVED WORKSFORME

(Toolkit :: Startup and Profile System, defect)

Description

[aleth [:aleth]]

When packaged, browser/omni.ja contains files in defaults/profile that should be copied to fresh profiles. However, this does not happen - probably because the code in [1] does not support omni.ja.

Is this a bug, or are these files dead code?

[1] http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/profile/nsToolkitProfileService.cpp?mark=783#783

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

I don't know this code all that well. Looking at hg blame, maybe smaug can help you.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I know nothing about omni.ja
Maybe bsmedberg knows.



(The code I changed was just for Bug 756131)

Comment 3

[Benjamin Smedberg]

This is dead code and should be removed. We should no longer support copying profile defaults when we create a new profile.

Comment 4

[aleth [:aleth]]

The files currently in browser/omni.ja/defaults/profile are

prefs.js
mimeTypes.rdf
localstore.rdf
bookmarks.html
chrome/userContent-example.css
chrome/userChrome-example.css

Currently the default contents of these files is likely not be populated correctly in fresh profiles. The user*.css examples are simply missing.

Comment 5

[Benjamin Smedberg]

That is intentional. We should stop shipping those files.

Comment 6

[:Gijs (he/him)]

Morphing per comment #5.

I guess we should also remove the unused code in nsToolkitProfileService?

Comment 7

[Benjamin Smedberg]

If Thunderbird isn't using it, yes.

Comment 8

[Dave Townsend [:mossop]]

It appears that we no longer ship these files.